Problem color local adjustment cromaticity curves

Dear all,

When I am making local adjustments, color and light, advanced curves, under curves, curve type normal, the C(h) histogram.

Whatever I do, does not matter if I increase or decrease saturation, the reds and in general saturation increase. Even if I decrease the corresponding histogram level.

Has anybody remark this? I am doing something incorrect?

Thank you in advance for your help!

@jdc

@hanay1978 @chaimav

Bad behavior confirmed.
Thank you.

I found why, I’m going to do a PR during the day.

Jacques

1 Like

Hello

PR created
https://github.com/Beep6581/RawTherapee/pull/6964

jacques

Hello,

I am sorry, but I believe I am not fully following.

What is PR?

Was it a bug? In case so, was it fixed? Can I download and compile the code? or what are the steps for me now?

Thanks in advance!

@hanay1978

Don’t be afraid, this is just development gibberish.

You reported a malfunction of C(h). Rather than doing the change directly, we suggest to be sure that it is true that we create what we call a “Pull Request” (PR), that is to say a “branch” separate from the main branch.

In this case, this branch is called “lachroma”.
And the Pull Request (PR) is here:
https://github.com/Beep6581/RawTherapee/pull/6964

I just asked to make executables (appimage and windows) so that you can test, if you don’t have a compiler.
Wait 15 to 30 mn.
They will appear here (with lachroma in the title).
https://github.com/Beep6581/RawTherapee/releases/tag/pre-dev-github-actions

Jacques

Thanks! I tested it, and as far as I know the problem has been corrected.

About the histogram of the curves: why are some areas marked in grey? I was looking in the documentation but did not found that described!

Thank you very much again!

@hanay1978

Thank you , I will push the Pull Request soon.

About the histogram of the curves.

The difference in gray, the separation line makes it possible to identify the characteristics of the RT-spot (central circle) which make it possible to manage the deltaE and therefore the colors and luminances concerned by the change.
Depending on the chosen curve, either the reference luminance, chroma or hue will appear.
Move the RT-spot and you will see this limit evolve.
This functionality is also available in masks
image

Jacques