RawTherapee 5.4 released!

heckflosse · March 22, 2018, 4:48pm

@gaaned92 Sorry, I really thought you were looking for the icons

Thomas · March 22, 2018, 4:52pm

Thanks !

viv · March 22, 2018, 5:13pm

Strange color shift while black and white conversion you can see here:

Morgan_Hardwood · March 22, 2018, 5:25pm

@viv please upload a raw file + PP3 + screenshot with 5.3 and 5.4. You can host the files on https://filebin.net/
Preferably on GitHub, though here is ok if you don’t want a GitHub account.

heckflosse · March 22, 2018, 6:10pm

Bug confirmed

viv · March 22, 2018, 6:29pm

https://filebin.net/lt4o0q5klxbf5rsy

nosle · March 22, 2018, 9:47pm

The ps icons are visible in my linux builds so I guess it’s a windows thing. Will have another look tomorrow at work if i find the time to reinstall etc.

gaaned92 · March 22, 2018, 11:39pm

You are welcome Ingo, You made me laugh

I see the PS and HDR icons with 5.4.

RawConvert · March 23, 2018, 11:09am

Though on the plus side, it’s good that the blue gamma slider is now having some effect with Prophoto working space

cuniek · March 23, 2018, 11:28am

Turn the LAB tool on and the cast is gone!

viv · March 23, 2018, 11:47am

Hmmm. The cast is gone when I turn LAB on. Why ??

Morgan_Hardwood · March 23, 2018, 11:51am

The bug was in the interaction between Lab and the B&W tool’s gamma settings.

cuniek · March 23, 2018, 11:51am

Dont know. Just noticed that. Test for yourself.

floessie · March 23, 2018, 11:52am

Bisected to added on/off switch for L*a*b* adjustments · Beep6581/RawTherapee@e1bf4b0 · GitHub.

floessie · March 23, 2018, 12:07pm

Preliminary fix:

diff --git a/rtengine/improcfun.cc b/rtengine/improcfun.cc
index a55624218..983f96499 100644
--- a/rtengine/improcfun.cc
+++ b/rtengine/improcfun.cc
@@ -5407,7 +5407,7 @@ void ImProcFunctions::luminanceCurve (LabImage* lold, LabImage* lnew, LUTf & cur
 
 void ImProcFunctions::chromiLuminanceCurve (PipetteBuffer *pipetteBuffer, int pW, LabImage* lold, LabImage* lnew, LUTf & acurve, LUTf & bcurve, LUTf & satcurve, LUTf & lhskcurve, LUTf & clcurve, LUTf & curve, bool utili, bool autili, bool butili, bool ccutili, bool cclutili, bool clcutili, LUTu &histCCurve, LUTu &histLCurve)
 {
-    if (!params->labCurve.enabled) {
+    if (!params->labCurve.enabled && !params->blackwhite.enabled) {
         return;
     }

HTH,
Flössie

Jossie · March 23, 2018, 12:54pm

Hello,

first of all I would like to thank all those who worked on the new release! Great stuff.

There is a small problem with the features “open with RT” and “browse with RT” for the right mouse button. They only work for the administrator (Win10 64bit), who did the installation. They cannot be found for a standard user, which I normally are, since I do not work with administrator privileges all the time for security reasons.

Best wishes

Hermann-Josef

Morgan_Hardwood · March 23, 2018, 12:57pm

All registry keys are installed for the “current” user:

github.com

Beep6581/RawTherapee/blob/dev/tools/win/InnoSetup/WindowsInnoSetup.iss.in#L131

    
      
          Source: "{#MyBuildBasePath}\fonts\DroidSansMonoSlashed.ttf"; DestDir: "{fonts}"; FontInstall: "Droid Sans Mono Slashed"; Flags: onlyifdoesntexist uninsneveruninstall
          ; NOTE: Don't use "Flags: ignoreversion" on any shared system files
          
          
[Icons]
          Name: "{group}\{#MyAppName} {#MyAppVersion}"; Filename: "{app}\{#MyAppExeName}"
          Name: "{group}\{cm:ProgramOnTheWeb,{#MyAppName}}"; Filename: "{#MyAppURL}"
          Name: "{group}\{cm:UninstallProgram,{#MyAppName} {#MyAppVersion}}"; Filename: "{uninstallexe}"
          Name: "{commondesktop}\{#MyAppName} {#MyAppVersion}"; Filename: "{app}\{#MyAppExeName}"; Tasks: desktopicon and commoninstall
          Name: "{userdesktop}\{#MyAppName} {#MyAppVersion}"; Filename: "{app}\{#MyAppExeName}"; Tasks: desktopicon and userinstall
          Name: "{userappdata}\Microsoft\Internet Explorer\Quick Launch\{#MyAppName} {#MyAppVersion}"; Filename: "{app}\{#MyAppExeName}"; Tasks: quicklaunchicon
          
          
[Run]
          Filename: "{app}\{#MyAppExeName}"; Description: "{cm:LaunchProgram,{#StringChange(MyAppName, '&', '&&')}}"; Flags: nowait postinstall skipifsilent
          
          
[Registry]
          Root: HKCU; Subkey: "SOFTWARE\Classes\Directory\shell\Browse with RawTherapee"; ValueType: string; ValueData: "Browse with RawTherapee"; Flags: uninsdeletekey; Tasks: regBrowseFolder and userinstall
          Root: HKCU; Subkey: "SOFTWARE\Classes\Directory\shell\Browse with RawTherapee\command"; ValueType: string; ValueData: "{app}\{#MyAppExeName} -w ""%1"""; Flags: uninsdeletekey; Tasks: regBrowseFolder and userinstall
          Root: HKCU; Subkey: "SOFTWARE\Classes\*\shell\Open with RawTherapee"; ValueType: string; ValueData: "Open with RawTherapee"; Flags: uninsdeletekey; Tasks: regOpenFile and userinstall
          Root: HKCU; Subkey: "SOFTWARE\Classes\*\shell\Open with RawTherapee\command"; ValueType: string; ValueData: "{app}\{#MyAppExeName} -R ""%1"""; Flags: uninsdeletekey; Tasks: regOpenFile and userinstall
          Root: HKCU; Subkey: "SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths\{#MyAppExeName}"; ValueType: string; ValueData: "{app}\{#MyAppExeName}"; Flags: uninsdeletekey; Tasks: userinstall
          Root: HKCU; Subkey: "SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths\{#MyAppCliExeName}"; ValueType: string; ValueData: "{app}\{#MyAppCliExeName}"; Flags: uninsdeletekey; Tasks: userinstall

Maybe HKLM would be better? Ping @gaaned92 @sguyader

agriggio · March 23, 2018, 1:29pm

@floessie I’m afrait this won’t work properly, e.g. what happens if you have the lab tool turned off but a non-linear L curve set?

floessie · March 23, 2018, 1:44pm

Alberto, that’s why I wrote “preliminary”, as there are other independent params inside this function…

agriggio · March 23, 2018, 1:45pm

I’m sure you knew that, but if you write “fix” people might misunderstand
Anyway, I’m working on it… and thanks for putting me on the right track!