[solved] Critical bug in TooWaBlue theme

bug

(Jacek Gozdz) #1

Hello

For several days I tried to nail a nasty bug that is crashing RT 5 every time I try to open folder with 600+ photos (in this case sony ARW or nikon NEF). RT crashes randomly. Sometimes after opening 4% of files, sometimes after 50%, and it does not matter weather files have their thumbnails already created or not. I finally found it is caused by “TooWaBlue” theme (both: normal and dark). RT works fine when I change theme to (ugly) “RawTherapee”.

Reproduction:
-Open RT when “TooWaBlue” theme is set.
-Open folder with at least 600 photos -> crash (no console output in debug mode)

System:
Win 7 64 bit, core i7, 16 Gb RAM, SSD drives

Affected versions:

tested on

Version: 5.0-r1-gtk3
Branch: 5.0-r1-gtk3
Commit: 50114c1a
Commit date: 2017-02-01
Compiler: gcc 6.3.0
Processor: generic x86
System: Windows
Bit depth: 64 bits
Gtkmm: V3.22.0
Build type: release
Build flags: -m64 -mwin32 -mthreads -Werror=unused-label -Werror=unknown-pragmas -Wno-aggressive-loop-optimizations -std=gnu++11 -mtune=generic -Werror=unused-label -fopenmp -Werror=unknown-pragmas -mwindows -DNDEBUG -msse2 -O3
Link flags: -m64 -mthreads -static-libgcc -mtune=generic -mwindows -s -O3
OpenMP support: ON
MMAP support: ON

and

Version: 5.0-r1-gtk3-6-gf9bd9956
Branch: dev
Commit: f9bd9956
Commit date: 2017-02-10
Compiler: gcc 6.3.0
Processor: generic x86
System: Windows
Bit depth: 64 bits
Gtkmm: V3.22.0
Build type: release
Build flags: -m64 -mwin32 -mthreads -Werror=unused-label -Werror=unknown-pragmas -Wno-aggressive-loop-optimizations -std=gnu++11 -mtune=generic -Werror=unused-label -fopenmp -Werror=unknown-pragmas -mwindows -DNDEBUG -msse2 -O3
Link flags: -m64 -mthreads -static-libgcc -mtune=generic -mwindows -s -O3
OpenMP support: ON
MMAP support: ON

worked perfectly fine with old “TooWaBlue” theme and RT 4.2.14xx


Segfault when the number of files gets to 908 files in the directory
#2

Hi @cuniek

Thanks for the info. I can confirm this issue. I will try to fix it.


#3

@cuniek

Can you test this theme, please?
TooWaBlueBugTest-GTK3-20_.txt (45,2 KB)

Rename .txt to .css and copy it in your theme folder.


(Jacek Gozdz) #4

Still crashing.

debug output

C:\Program Files\RawTherapee\5.0-r1-gtk3>rawtherapee_debug.exe
**
Gtk:ERROR:gtkcssinheritvalue.c:33:gtk_css_value_inherit_free: code should not be
 reached
**
Gtk:
C:\Program Files\RawTherapee\5.0-r1-gtk3>

#5

@cuniek

It looks like this is a Gtk3 bug. Because I’m doing much more in styling than the RawTherapee theme could be the reason why it affects only in the TooWaBlue theme. Sorry, I can’t do anything.

I’ve found others with the same error on the net but no fix.


#6

@cuniek
I think I’ve found a workarround for this weird bug. It doesn’t crash anymore on my computer.
Can you test it again, please?

TooWaBlueBugTest2-GTK3-20_.txt (45,2 KB)


(Jacek Gozdz) #7

@TooWaBoo

Great job, works perfectly!
I have tested it on both versions of RT I mentioned in initial post, on folders with 800+ and 1500+ photos, and no crash.

If someone ask - I changed the theme to bugtest2, cleared cache, and restarted RT.


#8

@TooWaBoo
Tested on a 850 NEF folder. Don’t crash with new theme.
Great job
André


(Peter Lavender) #9

Just a quick question on this bug, is it only related to the folder having so many raw files?

I’m getting RT to crash with the WB Slider, but I’m using the RT theme I think.


#10

@plaven for crash with WB slider, see https://github.com/Beep6581/RawTherapee/issues/3650


(Peter Lavender) #11

Thanks, checked it out. Even compiled a debug version to get a crash report and couldn’t…

Maybe it’s solved in the latest commits?


(Flössie) #12

I might have fixed it accidentally in #3677.


(Peter Lavender) #13

Hahaha, that’s awesome, quote of the year so far I think :slight_smile:


#14

Great, I’ve uploaded the fixed version on github.


(Peter Lavender) #15

The next question is, when will the PPA be updated with a new build? :slight_smile: