@gaaned92 that is all…
You’re welcome @todd
It’s really a small contribution, and I am happy that it can help.
By far, the main effort comes from the devs
Yes, thanks to all !
btw: i dont find the poormandehaze implented in the GUI? Is It still standalone by picking the values fom the textfile?
Yes, regretfully, it was not merged in the dev branch. ping @heckflosse
Just a display of values is sufficient. At this time, automatic correction is neither desirable nor needed.
From me, too: thanks to all! RT is great, it’s fun to use it and I always look forward to the next dev build - and release of course
hmmmm, my skylake version got a problem: doubleclicking on a favorite folder in the explorer tab shuts down the RT. This didnt happen in earlier versions.
crash with last version
Version: 5.8-3058-gbffc8c11d
Branch: dev
Commit: bffc8c11d
Commit date: 2021-12-03
Compiler: cc 11.2.0
Processor: undefined
System: Windows
Bit depth: 64 bits
Gtkmm: V3.24.5
Lensfun: V0.3.95.0
Build type: debug
Build flags: -m64 -mwin32 -msse2 -mfpmath=sse -mthreads -fno-tree-loop-vectorize -Wno-aggressive-loop-optimizations -Wno-parentheses -std=c++11 -Werror=unused-label -Werror=delete-incomplete -fno-math-errno -Wno-attributes -Wall -Wuninitialized -Wcast-qual -Wno-deprecated-declarations -Wno-unused-result -Wunused-macros -fopenmp -Werror=unknown-pragmas -O1 -g2
Link flags: -m64 -mthreads -static-libgcc -O1
OpenMP support: ON
MMAP support: ON
Build OS: MINGW64_NT-10.0-19042 3.3.3-341.x86_64 x86_64
Build date: Fri, 10 Dec 2021 11:03:13 +0000 UTC
Build epoch: 1639134193
Build UUID: b9962d9b-c107-4655-9d30-215517f1976a
(gdb) bt full
#0 0x00007ff9b4fd3416 in ntdll!RtlWaitOnAddress ()
from C:\WINDOWS\SYSTEM32\ntdll.dll
No symbol table info available.
#1 0x00007ff9b4f9fcb4 in ntdll!RtlEnterCriticalSection ()
from C:\WINDOWS\SYSTEM32\ntdll.dll
No symbol table info available.
#2 0x00007ff9b4f9fae2 in ntdll!RtlEnterCriticalSection ()
from C:\WINDOWS\SYSTEM32\ntdll.dll
No symbol table info available.
#3 0x00007ff9783e08f3 in _cmsGetTime ()
from D:\rawtherapee\rtinstall\dev_release64generic\liblcms2-2.dll
No symbol table info available.
#4 0x00007ff9783d75e1 in cmsOpenProfileFromMem ()
from D:\rawtherapee\rtinstall\dev_release64generic\liblcms2-2.dll
No symbol table info available.
#5 0x00007ff76bea2ebe in rtengine::ICCStore::createFromMatrix (
matrix=matrix@entry=0x2d66b90d1e8, gamma=gamma@entry=false, name=...)
at D:/RAWTHERAPEE/RTSOURCE/rawtherapee/rtengine/iccstore.cc:1244
pbody = {10, 1668313716, 252, 36, 1684370275, 288, 40, 2004119668,
328, 20, 1651208308, 348, 20, 1918128707, 368, 14, 1733579331, 384,
14, 1649693251, 400, 14, 1918392666, 416, 20, 1733843290, 436, 20,
1649957210, 456, 20}
pcurve = <optimized out>
oprof = 0x2d66b90bd90
p = <optimized out>
#6 0x00007ff76c0abe9e in rtengine::Thumbnail::init (this=0x2d66b90d180)
at D:/RAWTHERAPEE/RTSOURCE/rawtherapee/rtengine/rtthumbnail.cc:1019
No locals.
#7 0x00007ff76bdacffa in Thumbnail::_loadThumbnail (
this=this@entry=0x2d66b8c5750, firstTrial=firstTrial@entry=true)
at D:/RAWTHERAPEE/RTSOURCE/rawtherapee/rtgui/thumbnail.cc:904
succ = <optimized out>
#8 0x00007ff76bdae836 in Thumbnail::Thumbnail (
this=this@entry=0x2d66b8c5750,
cm=cm@entry=0x7ff76c5d6160 <CacheManager::getInstance()::instance>,
fname=..., cf=cf@entry=0xf7881ff650)
at D:/RAWTHERAPEE/RTSOURCE/rawtherapee/rtgui/thumbnail.cc:69
No locals.
#9 0x00007ff76b952be1 in CacheManager::getEntry (
this=0x7ff76c5d6160 <CacheManager::getInstance()::instance>, fname=...)
at D:/RAWTHERAPEE/RTSOURCE/rawtherapee/rtgui/cachemanager.cc:109
imageData = {<rtengine::FramesMetaData> = {
_vptr.FramesMetaData = 0x7ff76c4c64c0 <vtable for CacheImageData+16>}, md5 = {static npos = 18446744073709551615,
string_ = "c34b7a05538184b9bd95e1ecde84e620"}, version = {
static npos = 18446744073709551615,
string_ = "5.8-3049-gd053f0245"}, supported = true,
format = FT_Raw, rankOld = -1 '▒', inTrashOld = false,
recentlySaved = false, timeValid = true, year = 2019,
month = 9 '\t', day = 23 '\027', hour = 9 '\t', min = 36 '$',
sec = 47 '/', exifValid = true, frameCount = 1, fnumber = 8,
shutter = 0.0040000000000000001, focalLen = 11, focalLen35mm = 0,
focusDist = 0, iso = 200, rating = 0, isHDR = false,
isPixelShift = false, sensortype = 1,
sampleFormat = rtengine::IIOSF_UNSIGNED_SHORT, lens = {
static npos = 18446744073709551615,
string_ = "Canon EF 11-24mm f/4L USM or Tamron Lens"}, camMake = {
static npos = 18446744073709551615, string_ = "Canon"},
camModel = {static npos = 18446744073709551615,
string_ = "EOS 5DS R"}, filetype = {
static npos = 18446744073709551615, string_ = "dng"}, expcomp = {
static npos = 18446744073709551615, string_ = "0.00"},
redAWBMul = -1, greenAWBMul = -1, blueAWBMul = -1, rotate = 0,
thumbImgType = 0}
error = <optimized out>
thumbnail = std::unique_ptr<Thumbnail> = {get() = {<No data fields>}}
md5 = "c34b7a05538184b9bd95e1ecde84e620"
cacheName = {static npos = 18446744073709551615,
string_ = "C:\\Users\\Andre\\AppData\\Local\\RawTherapee5-dev\\cache\\data\\459A7863.dng.c34b7a05538184b9bd95e1ecde84e620.txt"}
#10 0x00007ff76c228d3f in PreviewLoader::Impl::processNextJob (
this=0x2d66b9139c0)
at D:/RAWTHERAPEE/RTSOURCE/rawtherapee/rtgui/previewloader.cc:130
tmb = 0x0
j = {dir_id_ = 3, dir_entry_ = {static npos = 18446744073709551615,
string_ = "D:\\PHOTOSTEST\\test7\\459A7863.dng"}, listener_ =
0x2d66a852798}
last = <optimized out>
#11 0x00007ff76c236961 in sigc::bound_mem_functor0<void, PreviewLoader::Impl>::operator() (this=<optimized out>)
at C:/msys64/mingw64/include/sigc++-2.0/sigc++/functors/mem_fun.h:1991
No locals.
#12 sigc::adaptor_functor<sigc::bound_mem_functor0<void, PreviewLoader::Impl> >::operator() (this=<optimized out>)
at C:/msys64/mingw64/include/sigc++-2.0/sigc++/adaptors/adaptor_trait.h:256
No locals.
#13 sigc::internal::slot_call0<sigc::bound_mem_functor0<void, PreviewLoader::Impl>, void>::call_it (rep=<optimized out>)
at C:/msys64/mingw64/include/sigc++-2.0/sigc++/functors/slot.h:136
typed_rep = <optimized out>
#14 0x00007ff97a99fc6a in ?? ()
from D:\rawtherapee\rtinstall\dev_release64generic\libglibmm-2.4-1.dll
No symbol table info available.
#15 0x00007ff97b72956f in ?? ()
from D:\rawtherapee\rtinstall\dev_release64generic\libglib-2.0-0.dll
No symbol table info available.
#16 0x00007ff97b728b81 in ?? ()
from D:\rawtherapee\rtinstall\dev_release64generic\libglib-2.0-0.dll
No symbol table info available.
#17 0x00007ff9971a4d53 in ?? ()
from D:\rawtherapee\rtinstall\dev_release64generic\libwinpthread-1.dll
No symbol table info available.
#18 0x00007ff9b310af5a in msvcrt!_beginthreadex ()
from C:\WINDOWS\System32\msvcrt.dll
No symbol table info available.
#19 0x00007ff9b310b02c in msvcrt!_endthreadex ()
from C:\WINDOWS\System32\msvcrt.dll
No symbol table info available.
#20 0x00007ff9b3467034 in KERNEL32!BaseThreadInitThunk ()
from C:\WINDOWS\System32\kernel32.dll
No symbol table info available.
#21 0x00007ff9b4fc2651 in ntdll!RtlUserThreadStart ()
from C:\WINDOWS\SYSTEM32\ntdll.dll
No symbol table info available.
#22 0x0000000000000000 in ?? ()
No symbol table info available.
Backtrace stopped: previous frame inner to this frame (corrupt stack?)
(gdb)
@gaaned92 please try with gcc 10.3
gcc 11.2 is kind of buggy on msys2
I had to revert to 10.3
thanks OK
Going to rebuild in the afternoon (french time!)
hi @gaaned92 did you rebuild it? I downloaded the RawTherapee_dev_5.8-3058-gbffc8c11d_W64_Skylake_211203 yesterday and the segfault after doubleclicking the favorite folder still exists.
Now, with this version some pics look very weird, even when set to neutral:
Whats wrong here?
Edit:
the exported tif of the former edited ([Version] AppVersion=5.8 Version=346) and the export of the set to neutral pic, both also contain this damage:
Hi @Marter that’s very interesting (and annoying)! Could you share this raw file perhaps for further investigation?
sorry, my bad: these files indeed were damaged due to the recovering after a harddisc crash.
Choosing these files from the backup, everything is fine now.
edit: except the crash when clicking the favorite folder, still remains.
@gaaned92 merry christmas to you and everybody around here
Thanks a lot for the new build Version: 5.8-3064-g690fab3d0. I just downloaded and tried to start an edit. I am sorry to report, that, under windows 10, it also shuts down immediately by double-clicking a folder of the favorites in the explorer tab without any error message.
This behaviour is not reproducable in the former Version: 5.8-3049-gd053f0245
@marter I cannot reproduce this. 5.8-3064-g690fab3d0 works fine with my Win10 installation.
@marter Oh, sorry, I just saw that you installed skylake. I use the generic one…
@mozzihh thanks for your answer. The generic version i cannot run at all… its shutting down with loading the GUI.
I found, that in this version there is a exe-file for debug, but it doesn’t show any error message and shuts down with RT immediately. Trying to redirect the debug output to a txt-file also failed.
This on two different machines.
@marter thank you
I cannot reproduce, except if I open a folder containing jpg with peculiar dimensions as panoramas.
I just did a fresh build of 5.8-3064 to be sure.
- delete the cache file in your config folder.
- create a test folder with a few raw files
- set the RT startup directory in preferences to a folder containing no photo or better empty.
- start the generic then open the test folder
- if it doesn’t crash open a dir where it should crash
If it crashes (and I dont understand why it should crash) the next step is to try the debug build.
- edit your option file and set
verbose=true
- open a powershell window, go to the generic build directory.
- type
./gdb.exe rawtherapee-debug.exe
. - after loading the symbol table you get the prompt:
(GDB)
- type
run
- a lot of text describing RT initialisation will appear before the RT window opens. If you can detect a warning inside this text, copy it and paste it in your post here.
- once the RT window is opened, open the test directory an if it doen’t crash the offending directory
- when it crashes, go back to the powershell
- after the (gdb) prompt type
bt full
- hopefully a traceback will be displayed. copy and paste in your post.
I will submit if needed an issue on github
Good luck and thank you in advance.
It might help not only to delete the cache folder but the whole RT-folder in C:\Users<user>\AppData\Local\RawTherapee (or whatever the name of the RT-folder is). I remember that I had some strange behaviour with the options file once when I made an update installation. Simply try a fresh install.
Yes, deleting the whole config folder, thus doing a fresh start is better.
@gaaned92 thank you for the detailled instructions
What id did:
Deleted my actual RT-folders of dev RawTherapee_dev_5.8-3064-W64_generic and downloaded this one: RawTherapee_dev_5.8-3064-g690fab3d0_W64_generic_211221
deleted the cache file in my config folder and also i deleted the C:\Users\AppData\Local\RawTherapee
I created a test folder with a few raw files andc also set the RT startup directory to an empty folder
RT crashed after starting the generic and trying to open the test folder…
Thus i followed your (very good and easy to follow) instructions to use the debug build
set verbose=true and before getting the RT-window i saw some messages like:
trying to load extra working spaces from C:\programme\rawtherapee\RawTherapee_dev_5.8-3064-g690fab3d0_W64_generic_211221.\iccprofiles\workingspaces.json FAIL
trying to load extra working spaces from C:\WINDOWS\System32\spool\drivers\color\workingspaces.json FAIL
[Thread 10892.0x1cd4 exited with code 0]
[New Thread 10892.0x2d3c]
[Thread 10892.0x2d3c exited with code 0]
[New Thread 10892.0x2a28]
At this point RawTherapee didn’t crash but after opening some folders it was totally blocked… later it shut down with closing the Powershell
Following the error codes i was able to copy and paste:
Error code 4 w[New Thread 10892.0x2850]
hile r[New Thread 10892.0x2610]
eading values from “C:\Users\Wonni[New Thread 10892.0x4ec]
[New Thread 10892.0x354]
\A[New Thread 10892.0x2c74]
[New Thread 10892.0x1a78]
[New Thread 10892.0xe3c]
p[New Thread 10892.0x53c]
pDa[New Thread 10892.0x26e8]
ta\Local\RawTherapee5-dev\cache\data\DSC01101.JPG.2ac6a528efb84096664140f5606d71ab.txt”:
No such file or directory
CacheImageData::load / Error code 4 while reading values from “C:\Users\Wonni\AppData\Local\RawTherapee5-dev\cache\data\DSC01102.JPG.18e5481a97ad0c82cd676c5722a7a345.txt”:
No such file or directory
CacheImageData::load / Error code 4 while reading values from “C:\Users\Wonni\AppData\Local\RawTherapee5-dev\cache\data\DSC01103.JPG.8d8629f6509ece5b699e4cb6b12b39d7.txt”:
No such file or directory
CacheImageData::load / Error code 4 while reading values from “C:\Users\Wonni\AppData\Local\RawTherapee5-dev\cache\data\DSC01104_hd.jpg.da2fc133ebe53216b93765f5a9578b59.txt”:
No such file or directory
CacheImageData::load / Error code 4 while reading values from “C:\Users\Wonni\AppData\Local\RawTherapee5-dev\cache\data\DSC01104.JPG.d714ea4d4609c8bd9e2be86899bd6a67.txt”:
No such file or directory
CacheImageData::load / Error code 4 while reading values from “C:\Users\Wonni\AppData\Local\RawTherapee5-dev\cache\data\DSC01105.JPG.f7809fb8e9bd1de18d598d8325664a7f.txt”:
No such file or directory
CacheImageData::load / Error code 4 while reading values from “C:\Users\Wonni\AppData\Local\RawTherapee5-dev\cache\data\DSC01105_hd.jpg.42b7aff625ac2e25a73e5d61f6702392.txt”:
No such file or directory
CacheImageData::load / Error code 4 while reading values from “C:\Users\Wonni\AppData\Local\RawTherapee5-dev\cache\data\DSC01105_kl.jpg.99438dcc93437aa1c9b7a4cb1dc6b9fc.txt”:
No such file or directory
CacheImageData::load / Error code 4 while reading values from “C:\Users\Wonni\AppData\Local\RawTherapee5-dev\cache\data\DSC01106.JPG.3823ab0a186e8c9a7df3cac667451260.txt”:
No such file or directory
CacheImageData::load / Error code 4 while reading values from “C:\Users\Wonni\AppData\Local\RawTherapee5-dev\cache\data\DSC01107.JPG.9fb1f480f68ff0370b8b0f7303cea4a7.txt”:
No such file or directory
CacheImageData::load / Error code 4 while reading values from “C:\Users\Wonni\AppData\Local\RawTherapee5-dev\cache\data\DSC01108.JPG.d6a47ccc92133bb55ccce7d23620d1da.txt”:
No such file or directory
–Type RET for more, q to quit, c to continue without paging–
At this point RT was blocked and typing RET in Powershell ended up here:
Thread 975 “pool-rawtherape” received signal SIGSEGV, Segmentation fault.
[Switching to Thread 10892.0x418]
0x00007ff8afd33416 in ?? ()
(gdb) bt full
#0 0x00007ff8afd33416 in ?? ()
No symbol table info available.
Backtrace stopped: previous frame identical to this frame (corrupt stack?)
(gdb) bt full
#0 0x00007ff8afd33416 in ?? ()
No symbol table info available.
Backtrace stopped: previous frame identical to this frame (corrupt stack?)
(gdb)
Hope, you can find the information, you asked for….