Working with modules from Lua scripts in darktable

kichererbse · February 3, 2023, 8:10am

Bielefeld? Das gibts wirklich??

Ulrich_Gesing · February 3, 2023, 8:21am

This question was really unexpected - Yes, despite all the rumours: This city of Bielefeld in East Westphalia really does exist

Sciencenerd · February 4, 2023, 5:51pm

Okay, here is my try to incorporate local contrast into your script, as well as the option to apply the tone equalizer medium shadow/highlight compress, which I often use when processing pictures with strong backlighting.

InitialWorkflowModule.zip (5.3 KB)

Thanks again for the template, this is a fun project.

BTW: I am from Frankfurt, but have been living in the US for 20+ years.

Ulrich_Gesing · February 8, 2023, 7:06pm

Hi @Sciencenerd,

thanks for your additions. Currently I try to add them to the next version of the script.

There seems to be a bug in tone equalizer module: Using lua to set “compress shadows-highlights (eigf):”, only “medium” works. If I replace medium with “soft” or “strong”, the action path is not found. Can you reproduce that?

dt.gui.action(“iop/toneequal/preset/compress shadows-highlights (eigf): medium”, 0, “button”, “on”, 1.0)

priort · February 8, 2023, 7:54pm

Medium is first in the preset list…could it be you also need to specific the position in the list??

Ulrich_Gesing · February 8, 2023, 7:58pm

I don´t think so, because others like “(gf): soft” work.

Sciencenerd · February 8, 2023, 8:40pm

I only tried the tone equalizer compress highlights/shadows medium preset. I’ll have to try the other presets when I have more time over the weekend, unfortunately, I have to work tonight and the next two nights.

As to the script, I also had a problem like the one reported in an earlier post in this thread, when some images are processed multiple times. In darkroom view, it looks like the script is moving on to the next image in the filmstrip, but it is reprocessing the same image. Eventually, it moves on, but then one or several images were skipped (not processed). I have tried to trouble shoot with the logging function, but my lua script skills are not good enough yet to figure out the problem.

Again, this is a great script and thanks for contributing and improving it.

Ulrich_Gesing · February 8, 2023, 8:48pm

@Sciencenerd, thanks for your support. That definitely has time until the weekend.

I will investigate the reported problem, but I can’t reproduce it yet. It may not happen in my current version.

Do you use the official DT 4.2 release? Or any newer DT 4.3 nightly build?

Sciencenerd · February 8, 2023, 8:58pm

I have darktable 4.2 on windows. I have a feeling that it has something to do with the processing not complete before the script wants to move on to the next image, but I have no evidence for this. I did, at one point, try to turn on the higher level debugging in the script
debug.max_depth = 3
log.msg(log.always, 4, dt.debug.dump(image))
local d = dt.gui.libs.modulegroups
log.msg(log.always, 4, dt.debug.dump(d)))

and this seemed to improve things a lot (but did not 100% eliminate the issue), maybe be slowing down the script?

Ulrich_Gesing · February 8, 2023, 9:03pm

do you process multiple images from lighttable view?

maybe the script doesnt allway wait until the single steps are finished.

Give me some time, I will post the new version in a few days. Perhaps that will solve it.

priort · February 8, 2023, 9:49pm

It was a crazy guess but stranger things as they often say ……

I need to learn some of this code… … It will have to wait for now…

Ulrich_Gesing · February 8, 2023, 10:01pm

thats okay, you could wait for the next version.

The last days I learned a bit about lua and made a complete rework. It will be easier to extend (and perhaps to understand).

I’m still learning, coming from .Net it’s a new language for me, and a new API. But it’s fun

Good Night

Sciencenerd · February 8, 2023, 10:10pm

Yes, I always select multiple images in lighttable view, then start the script. In fact, when I select multiple images in darktable, the script only processes the currently viewed, active image and then stops.

priort · February 9, 2023, 5:12am

If you do the same for something like export it will only export one image when in darkroom view as well…

Sciencenerd · February 12, 2023, 2:27pm

Hi Uli,

I just tried and can replicate our finding that some presets in Tone Equalizer (for example compress h/s (eigf) soft and strong) don’t work when called the LUA script. I have no idea why.

Chris

priort · February 12, 2023, 2:48pm

@wpferguson Bill might have a thought on this one??

Ulrich_Gesing · February 12, 2023, 3:18pm

medium works:
dt.gui.action(“iop/toneequal/preset/compress shadows-highlights (eigf): medium”, 0, “button”, “on”, 1.0)

others like “(gf): soft” work, too, but “(eigf) soft” and “(eigf) strong” do not work.

wpferguson · February 12, 2023, 5:52pm

try

dt.gui.action(“iop/toneequal/preset/compress shadows/highlights (eigf): medium”, 0, “”, “”, 1.0)

Ulrich_Gesing · February 12, 2023, 6:54pm

same result for “strong” and “soft”:

[dt_action_locate] action ‘compress shadows-highlights (eigf): strong’ doesn’t exist
[dt_action_process] action path ‘iop/toneequal/preset/compress shadows-highlights (eigf): strong’ not found

davidvj · February 12, 2023, 7:16pm

The git version of dt-4.3 is updated daily on Arch.