write response curve from command line

nuki · September 25, 2019, 11:59pm

Is there an option to write a Response Curve Output file via the command line? I was hoping the --hdrCurveFilename arg would WRITE the file if it doesnt exists (in combination with robertson) but it doesnt seem to work that way.
I have a few image sets that I would like to create responses from, then average them together.

Morgan_Hardwood · September 26, 2019, 10:32am

Seems saving it from the command line is currently not possible, as the response curve output filename is set only when using the UI:

github.com

LuminanceHDR/LuminanceHDR/blob/master/src/HdrWizard/HdrCreationManager.cpp#L388

    
      
                  frames.push_back(
                      FrameEnhanced(m_data[idx].frame(),
                                    std::pow(2.f, m_data[idx].getEV() - m_evOffset)));
              }
          
          
    libhdr::fusion::FusionOperatorPtr fusionOperatorPtr =
                  IFusionOperator::build(m_fusionOperator);
              pfs::Frame *outputFrame(
                  fusionOperatorPtr->computeFusion(*m_response, *m_weight, frames));
          
          
    if (!m_responseCurveOutputFilename.isEmpty()) {
                  m_response->writeToFile(
                      QFile::encodeName(m_responseCurveOutputFilename).constData());
              }
          
          
    return outputFrame;
          }
          
          
void HdrCreationManager::applyShiftsToItems(
              const QList<QPair<int, int>> &hvOffsets) {
              int size = m_data.size();

I opened an issue about the ambiguous CLI option:
https://github.com/LuminanceHDR/LuminanceHDR/issues/208

As a workaround, if you want to create the camera response curve file via CLI, hardcode the path like so:

diff --git a/src/HdrWizard/HdrCreationManager.cpp b/src/HdrWizard/HdrCreationManager.cpp
index 5b2789ec..a5d2f1d8 100644
--- a/src/HdrWizard/HdrCreationManager.cpp
+++ b/src/HdrWizard/HdrCreationManager.cpp
@@ -385,6 +385,7 @@ pfs::Frame *HdrCreationManager::createHdr() {
     pfs::Frame *outputFrame(
         fusionOperatorPtr->computeFusion(*m_response, *m_weight, frames));
 
+    setResponseCurveOutputFile("/tmp/crc.m");
     if (!m_responseCurveOutputFilename.isEmpty()) {
         m_response->writeToFile(
             QFile::encodeName(m_responseCurveOutputFilename).constData());

nuki · September 26, 2019, 1:46pm

ah, ok. I guess hardcoding will do the trick for now, thank you! Good to know that there already is an issue open for this too.