Blender AgX in darktable (proof of concept)

I have seen recently I think at least for RT that some recent updates might be slowing Rawtherapee down for builds made after recently updating msys2… I will run both and try to see if I can see any issues…I only know how to performance check from the command line so if the slowdown is real and comes from some part of the gui or other internals I might not see it…

If I find out anything useful I will share it but as I mentioned already I could open the files in the one you had issues with so it might be something further going on for you???

I’m off to vacation. I’ll probably work a bit on the docs towards the end, but will not have access to a proper coding environment (I’ll have a Raspberry Pi 4). I wouldn’t want to have one, anyway (‘too much of a good thing’ and all that). :smiley:

7 Likes

Disconnect and have fun…

I was in 2019 cyling with my wife in Austria and northern Italy. We had a fantastic trip… The next year was to be Amsterdam and Brussels…COVID messed that up…in the intermediate time my wife who was a healthcare worker experienced a number of issues such that we chased for a diagnosis depression , extreme fatigue, brain tumors, long COVID, cardiovascular issues and a few other possible illnesses with no clear outcome to explain all her symptoms but after a CT and follow-up MRI imaging she was finally been diagnosed as having early onset frontotemporal dementia…behaviour variant… In that short period of time she has become 180 degree version of herself (mentally and physically) and now life is very different…no travel and some days lots of challenges…she is 62 and had to retire due to this and well I am working but not sure for how much longer but retirement will look very different that what I imagined…

So people can wait a bit for you to have some fun away with your family… :slight_smile:

25 Likes

I’m very sorry to hear that. Lots of strength to you and I hope her condition doesn’t degrade quickly.

I agree with Todd, enjoy your vacation and forget about work for a while :slight_smile:

3 Likes

That’s horrible, Todd. I wish both of you strength and patience.

4 Likes

@kofa and @hatsnp

Thanks guys…It is hard to watch someone who was always so full of life go through this… So many changes. I am learning to repeat things many times and not get mad or frustrated… as much :slight_smile: even though you know they can’t help it, it becomes so hard remember and not get easily frustrated… But we will take things as they come…

Life will take things away from you soon enough so that is why it is good to do things when you think of them…this artificial boundary of retirement and waiting to do things is really in the end robbing a lot of people. By the time it comes we are older and other things happen… we may have the money but if we don’t have our health then its not of much use…

It reminds me to try and be present and appreciate time with friends and family…

All the rest can wait…

I am very grateful for the short chats and interactions that I have with all of you on the forum. Its my little escape from reality… you are all part of my personal wellness support team even though you might not have known it :slight_smile:

27 Likes

So sorry to hear this, sounds very difficult, but as you say it is a lesson to take opportunities when you can. Glad that this forum provides an escape. From the way it is conducted, you seem a bunch of kind respectful people.

2 Likes

Post deleted by author

So sorry to hear this. There’s very little people can say but you’re right, take each day as a blessing. When you get to a certain age, which you never saw coming, friends and relatives get ill or disappear. I have terminal cancer and currently in remission. Photography keeps me sane. I’m not a talented photographer and much prefer pretending to be an artist thanks DT and gimp. I don’t think about my position but worry about those I hold dear.

7 Likes

Thanks again…so as not to hijack the topic any further I will pm a few of you back… just to say thank you…

It was just a moment and opportunity to express my personal version of stop and smell the roses and do “only” or as many things as you can that will enrich your life and bring you joy…and do those things often and sooner rather than later… :slight_smile:

21 Likes

Hey dude I think it’s totally okay and no one will think you’re hijacking. Sorry to hear about your troubles and I think that you gave good advice to disconnect and just do the important things in life, which is so short. Thoughts go out to you man :slight_smile:

6 Likes

I’m a bit late to the game and try to catch up, but I can’t read all the 1731 messages in this thread. So I am sorry if some points have been brought up in the past - I’ve tried to search within the topic.

First, I really like the module.
Thank you very much!
With the well-chosen basic curve parameters, it strikes a good balance between control and usability.
One suggestion: toe and shoulder are common terms in video color grading, but a bit less known in the photo world.
As, in very simplified terms, they adjust shadows and highlights, maybe it could be helpful for beginners to mention this?
like “toe power (shadows)” and “shoulder power (highlights)”

Second observation: The hue preservation in the look tab is often not required to get nice looks. In some situations, it can be crucial, however.
In particular when doing portrait work with the requirement for accurate skin tone reproduction (where bright regions break) and generally if bright non-primary colors must be preserved.
Here, the current hue preservation in HSV within the agx base space tends to reduce the brightness quite a lot as it preserves the saturation.
In my personal perspective, I often find this undesirable.
See the example below: First is with hue recovery 0 and the second with 1.


Maybe it might be useful to adapt some methods that provide more control in this regard?
For example https://library.imaging.org/ei/articles/37/10/IPAS-226 provides some straight-forward ways, but the choice of appropriate RGB space, transfer curve and luma coefficients are crucial.
In my experiments with the base curve (An improved Basecurve Module) I experimented with recovery in OKlab / OKhcl and this yielded surprisingly nice results IMO as OK predicts the perceived lightness quite well.
In the current agx implementation this would, however, be a bit complicated as currently hue recovery is done in the base space and trafo to OKhcl would require a roundtrip back to XYZ, right?

2 Likes

@Wilecoyote , that’s an interesting post. Would you perhaps be able to share the raw pls?

I feel like it’s in a previous play taw or topic…

I’m sorry, but I don’t have permission to share the raw as the whole person in depicted and the image above is a crop…
But I’ll look for another suitable example as soon as possible!

1 Like

There is a good image with those colors. I think Boris used it …It was a person in one of those orange visibility vests directing traffic or part of a crew… it was part of the filmic salmon red discussions …I’ll see if I can find that one

2 Likes

@priort Here it’s the photo about the people with vests Introducing "primaries" feature for sigmoid - #58 by s7habo

1 Like

That was the one I was thinking of…thx

1 Like

@rgo Thanks!
Below is also an example from my photos - with heavily oversaturated colors to emphasize the effect.
From an aesthetic point of view, I like the shift to yellow in this Situation.
There are other situations however, where this may be a no-go.
In particular in product photography or some portrait work, color accuracy is crucial and you may even profile your camera and make a color profile for the lighting setup using a color checker. If the tone mapper then breaks the color pipeline, this may be difficult! (That’s not an AGX-Specific problem though :wink: - but as the hue preservation already exists in the module, it might be positive to design it as good as possible)

There is also an image on Dpreview which is great to illustrate the hue shift problems for portrait work that can arise especially when working with persons of color:
https://www.dpreview.com/sample-galleries/8491664854/sigma-bf-sample-gallery/4138115018
(Please remember not to share edits of this as dpreview provides the images for personal use only!)
Here, if you adjust exposure, increase saturation a bit and use AGX with increased contrast, you’ll notice that the skin colors break completely on brighter areas.
Hue preservation does magic here.

DSC03063.ARW (38.5 MB)

This file is licensed under the Deed - Attribution-ShareAlike 4.0 International - Creative Commons

Without hue preservation:


DSC03063_02.ARW.xmp (16.7 KB)

With hue preservation (Note the darkening of the flower’s yellow parts and also the slight reduction of contrast in the green background):


DSC03063_03.ARW.xmp (20.4 KB)

And for reference an underexposed (=without channel clipping) version without agx to illustrate that the hue preservation is indeed preserving the hue while agx without hue preservation introduces a shift to yelllow)


DSC03063_04.ARW.xmp (21.9 KB)

2 Likes

Human vision itself does not preserve hue; there are all kinds of shifts. Just search the forum for salmon fire.

1 Like