make install or whatever failed to copy “icons” folder to the right place.
@heckflosse I will neither be of great help
1- Luminance-hdr.exe is installed in installdir/bin. How to do to install it directly in installdir?
2- to get the icons, I copied master/icons in installdir/bin:
robocopy <clonedir>/icons <installdir>/bin/icons -s
3- list of dependencies dependencies.txt (897 Bytes)
@Hombre is the one who set up innosetup for RT. perhaps he can help here.
And here https://drive.google.com/open?id=0B2q9OrgyDEfPS2FpdDAtMVI1RG8
I have uploaded an installer
LuminanceHDR_master_v.2.5.1-123-g17efa5b8_WinVista_64.exe
I have first to clean the the files. Then I dont know what to generate from my local repository, a patch or a dif and how to do (the simplest please)
What do you need ? I know how to create cmakefiles and innosetup too, but don’t know where things go in the linux tree, or do we talk about windows install only ?
@Hombre
we speak only about building with msys2 and generate an installer on windows.
I am trying to make a patch with all I made to build and make an installer.
A diff is not sufficient as I added files.
-
if you can explain how to make a patch with all added files, it would be fine
-
then your help will be useful and essential to check, clean and improve that
@gaaned92 What do you mean by “a patch with all added files” ? Could you share your patch with me already ? I could give some hint from this starting point. I’m installing lhdr as explained by @heckflosse. Damn, qt5 is huge !
@gaaned92 @Hombre hello, you guys can send a pull request on GitHub. That’s why git was created in the 1st place, no more patches floating around. Thank you.
@fcomida
You are right but really it is beyond my skills to do that as I have very rusty and rudimentary programming knowledge.
I made a patch installer.patch (128.9 KB) to be checked by knowledgeable people @Hombre @heckflosse or you.
Sure after checking you will make a PR for code review.
@fcomida I don’t know github enough to answer this question, but it’s not possible to commit to a PR of a forked repository, unless you have commit right to this fork ?
@gaaned92 Thanks, I’ll look at it asap.
@gaaned92 If you managed to make a patch you’ll find it’s even easier to send a pull request but of course you don’t have to. @heckflosse has his own fork of lhdr and a working msys2 environment for the patch or the pull request.
@Hombre that’s what pull requests are all about. You clone the repository locally, make your changes and then send a pull request, you don’t have to have commit rights. If you send a PR to me I can review your code and decide to pull it effectively doing a merge/commit. And git is distrubuted so you can send the PR to someone else ( @heckflosse ) and he will decide to accept/incorporate your changes and then he can send a PR to me since I have commit rights to the repo considered (only by convention) the “OFFICIAL LHDR REPOSITORY”
@fcomida Yes, I forked LHDR and will work on it. I only worked on RT so far, so this is a new behavior for me, but I’ll stick to the rule
@gaaned92 I’ll remove everything about AboutThisbuild. That’s not something lhdr is handling, so we won’t make things uselessly complex.
@Hombre no need for creating patches now, when you are happy with your changes just send a PR to @heckflosse fork, he can review/test them. I cannot do it right now.
Patch is almost done, only remaining things is how to find the location of the dependencies to create the Installer ?
I’ll be away for few hours. Let me post something around midnight or more probably tomorrow.
We have 2 situations to handle :
- The user build LHDR himself for himself, so he doesn’t need to copy the dll in the destination directory, adding msys64\mingw64\bin to the PATH suffice
- The user build LHDR to create a installable version, so the libs have to be copied to the base output dir before packaging.
My question is : do we care of point 2 in the cmakefile ?
I see no reason to care for point 2 in the cmakefile.
under Msys2, 64 bits dependencies(dlls) are found in /mingw64/bin
In linux we have rules in cmake for generating proper “make install” instructions and “make install” is also needed by rpmbuild for generating a rpm package (and maybe a deb package). In any case “help”, “icons” and “hdrhtml” folders must be subfolders of CMAKE_INSTALL_PREFIX for lhdr to run properly.
Edit:
What I mean is that, even without creating a package/installer, when run from <BUILD_ROOT> those folders are still relatives to <CMAKE_INSTALL_PREFIX>