@gaaned92 What do you mean by “a patch with all added files” ? Could you share your patch with me already ? I could give some hint from this starting point. I’m installing lhdr as explained by @heckflosse. Damn, qt5 is huge !
@gaaned92@Hombre hello, you guys can send a pull request on GitHub. That’s why git was created in the 1st place, no more patches floating around. Thank you.
@fcomida I don’t know github enough to answer this question, but it’s not possible to commit to a PR of a forked repository, unless you have commit right to this fork ?
@gaaned92 If you managed to make a patch you’ll find it’s even easier to send a pull request but of course you don’t have to. @heckflosse has his own fork of lhdr and a working msys2 environment for the patch or the pull request.
@Hombre that’s what pull requests are all about. You clone the repository locally, make your changes and then send a pull request, you don’t have to have commit rights. If you send a PR to me I can review your code and decide to pull it effectively doing a merge/commit. And git is distrubuted so you can send the PR to someone else ( @heckflosse ) and he will decide to accept/incorporate your changes and then he can send a PR to me since I have commit rights to the repo considered (only by convention) the “OFFICIAL LHDR REPOSITORY”
@Hombre no need for creating patches now, when you are happy with your changes just send a PR to @heckflosse fork, he can review/test them. I cannot do it right now.
The user build LHDR himself for himself, so he doesn’t need to copy the dll in the destination directory, adding msys64\mingw64\bin to the PATH suffice
The user build LHDR to create a installable version, so the libs have to be copied to the base output dir before packaging.
My question is : do we care of point 2 in the cmakefile ?
In linux we have rules in cmake for generating proper “make install” instructions and “make install” is also needed by rpmbuild for generating a rpm package (and maybe a deb package). In any case “help”, “icons” and “hdrhtml” folders must be subfolders of CMAKE_INSTALL_PREFIX for lhdr to run properly.
Edit:
What I mean is that, even without creating a package/installer, when run from <BUILD_ROOT> those folders are still relatives to <CMAKE_INSTALL_PREFIX>
I got a bug report for the LHDR build for windows:
New HDR Image → Imported raw files from my GH5(still happens with jpeg’s) → Message, that if could’nt find the exif tags → changes the EVF from the photos Manually → Programm alligns the photos (auto allign photos and anti ghosting is on) → I click on finish ( Default settings) → programm crashed with a windows message, “luminance-hdr.exe isn’t working”