Call for testing: My Luminance HDR fork with a lot of speedups and reduced memory usage

Morgan_Hardwood · March 19, 2018, 9:56am

FITS support was added to LHDR 4.5 years ago.

heckflosse · March 28, 2018, 12:36am

As @Hombre and I now got push access to the official Luminance HDR repository we merged a lot of stuff into the master branch.

As I don’t need my fork anymore, I will delete it soon. So please don’t build from it. All the speedups and other stuff now are in official master branch.

HIRAM · March 29, 2018, 12:24am

https://filebin.net/3qr3126sa79lndfg/Luminance_HDR_2.5.2-SNAPSHOT-Test1j.dmg

^ Latest mac build from LuminanceHDR/master

David_Wilson · March 29, 2018, 8:45pm

I have compiled an earlier version of LuminanceHDR, and I need to use the luminance-hdr-2.5.0-qtwebkit.patch patch file as version of linux does not have QtWebEngine.

This patch file does not not seem to work with your current version and does not seem to have been updated for 11 months. Or maybe I am running it incorrectly.

/test/LuminanceHDR-master$ patch -p1 < luminance-hdr-2.5.0-qtwebkit.patch
patching file CMakeLists.txt
Hunk #1 FAILED at 34.
Hunk #2 FAILED at 53.

heckflosse · March 29, 2018, 9:29pm

I would prefer to get rid of that patch file. Can you try without applying the patch and show the log file?

David_Wilson · March 30, 2018, 12:58am

Ingo,

Here is the command line output from the build

heckflosse · March 30, 2018, 1:05am

I don’t see the output

David_Wilson · March 30, 2018, 1:53am

Ingo,

What other output do you want. The compilation fails, I have the console messages from the build, and I have attached the cmake log ?

regards

David

gaaned92 · March 30, 2018, 9:41am

Luminance-HDR_master_v.2.5.1-194-g68aa044b_WinVista_64.exe

built from Luminance HDR repository is uploaded at

https://keybase.pub/gaaned92/LHDR64/

heckflosse · March 30, 2018, 10:13am

Where?

David_Wilson · March 30, 2018, 11:25am

Ingo,

It must be some problem in gmail dropping the attachment. I can see the log file attached in my version of the email on my desktop and my android tablet in the gmail app. Here is the screen print.

I will attach the log file again here.

regards

David

David_Wilson · March 30, 2018, 11:36am

I have put a copy of the log file on drive, in case the email system drops it again. Here is the link.

https://drive.google.com/file/d/0Bx8EoRB4WtGcSFcwWlBfUlFUVF9sMUtkaFVUekMxWXdzbjhr/view?usp=drivesdk

heckflosse · March 30, 2018, 12:06pm

Are you sure using the current master branch?
In your screenshot, there is an error in line 46, which in current code is a comment

github.com

LuminanceHDR/LuminanceHDR/blob/master/CMakeLists.txt#L46

    
      
          include(build_files/Modules/Version.cmake)
          include(build_files/Modules/GlobalSettings.cmake)
          include(build_files/Modules/CompilerSettings.cmake)
          include(build_files/Modules/Internationalization.cmake)
          
          
IF(TIMER_PROFILING)
              ADD_DEFINITIONS(-DTIMER_PROFILING)
          ENDIF()
          
          
# ======== Enable GNU gsl inline code =======
          IF(UNIX OR APPLE OR MINGW) # Visual Studio doesn't like this
              ADD_DEFINITIONS(-DHAVE_INLINE )
          ENDIF()
          
          
# ======== Has branch prediction =======
          include( CheckCXXSourceCompiles )
          
          
check_cxx_source_compiles( "int main() { int x = 0; if( __builtin_expect((x),0) ) x = 1; return 0; }" HAS_BRANCH_PREDICTION )
          
          
if( HAS_BRANCH_PREDICTION )
              set( BRANCH_PREDICTION 1 )

Morgan_Hardwood · March 30, 2018, 12:39pm

@David_Wilson follow this simple guide, and if compilation fails, attach the whole log, from the moment you typed “wget”, to the last line. Attach the log directly to this forum, or upload using https://filebin.net/ I won’t be following any Google Drive links which require me to “request access”, there’s no need to complicate things.

Morgan_Hardwood · March 30, 2018, 12:43pm

@gaaned92 your build Luminance-HDR_master_v.2.5.1-194-g68aa044b_WinVista_64.exe runs fine in wine.

HIRAM · March 30, 2018, 2:20pm

Since you were replying on email, the forum is stripping quoted material. Notice the quote level of your pasted-in text. Instead of a quote, surround the data with lines containing three backticks:

```

Pasted data

```

David_Wilson · March 31, 2018, 2:59am

I have followed Morgan_Hardwood’s directions.

Here is the clonsole log:

Here is the Cmake output log: https://filebin.net/lbmtppi3r0ezxnak/CMakeOutput.log

regards

David

Morgan_Hardwood · March 31, 2018, 1:33pm

@David_Wilson thank you, but that is not the log I requested.

David_Wilson · March 31, 2018, 9:30pm

Morgan_Hardwood
I truly do not understand what other log you want and would like to help.

in your last message you wrote

Perhaps when you wrote “follow this simple guide” you intended to link to some instructions ? I found your instruction for building HDRMerge elsewhere in the forum and followed those.

So I have the console output from the moment I typed “wget”, to the last line quoted in the email.

And the file.bin has the cmake output log.

heckflosse · March 31, 2018, 9:41pm

I confirm that there was no direct link to the ‘simple guide’, which was at least confusing.

I would like to know, whether you still get errors during build when building from latest lhdr code. And if you get errors (your latest log didn’t show errors or I missed them), please show the error messages.