HIRAM
(Richard E Barber)
January 5, 2019, 8:38pm
1
Do you have a mac with a Retina display or other system with a HiDPI monitor?
It would be great if we could get some full screenshots of RT branch hidpi-icons
running. Here is a build of this enhancement test branch for MacOS https://kd6kxr.keybase.pub/RawTherapee_OSX_10.9_64_5.5-82-g0407dc348.zip
Thanks @Hombre @TooWaBoo and others for the hard work getting the interface ready for hi-def.
\mathsf{\LARGE\color{lightblue}Note:\ Please\ select\ a\ TooWa*\ theme\ for\ this\ test,}
\\ \mathsf{\LARGE\color{lightblue}as\ it\ has\ been\ updated\ for\ hidpi,\ }
\\\mathsf{\LARGE\color{lightblue} whereas\ the\ default\ RawTherapee\ }
\\ \mathsf{\LARGE\color{lightblue} theme\ hasn't\ yet\ been.}
opened 06:50PM - 18 Dec 16 UTC
closed 12:18AM - 17 Mar 19 UTC
type: enhancement
The aim of this issue is to get RawTherapee to look well when scaled up, somethi… ng which is becoming increasingly common. The change should not cause a performance penalty.
Reading SVG icons is slow, but once they are read they will be drawn just as fast as PNG icons. As startup time does matter to us, we will use PNG icons. The icons will be stored as SVG in the repository, but will be converted to PNG for builds for performance reasons.
Steps:
- [x] Clean up icon situation, #4469
- [x] Use a script to render PNGs of various sizes, optimize, maybe create iconsets.
- [x] Remove `rtdata/images/*` and `tools/source_icons`
- [x] Keep SVGs separate from PNGs.
- [x] Do not ship SVGs with builds.
- [x] Update CSS themes as needed.
- [x] Implement HiDPI support in RT code - the UI including the preview and thumbnails should scale correctly.
https://wiki.gnome.org/HowDoI/HiDpi
2 Likes
Claes
January 5, 2019, 9:01pm
2
Only on Macs?
I have a HiDPI monitor but I am on Manjaro…
HIRAM
(Richard E Barber)
January 5, 2019, 9:05pm
3
Not only on macs! You just have to build the hidpi-icons
branch.
Claes
January 5, 2019, 9:20pm
4
OK, thanks.
WIll do it tomorrow (it’s bedtime over here).
Have fun!
Claes in Lund, Sweden
1 Like
Claes
January 6, 2019, 10:22am
5
Morning!
I fetched the hidpi-icons branch, compiled as usual,
and performed a rough/swift test for each resolution (see below).
Monitor = 28" Samsung
gfx GTX-1050
Resolutions tested
3840x2160
2560x1440
1920x1080
1280x1024
No peculiar icons found.
However, the Retinex module refused to expand,
irrespective of resolution (but that probably has nothing
to do with icons ).
Anything more you’d like me too look out for before
I go over to the dev version?
Have fun!
Claes in Lund, Sweden
PS: Oh, I just noted that you want full screenshots. One moment, please…
1 Like
HIRAM
(Richard E Barber)
January 6, 2019, 10:43am
7
@Claes awesome! Can you post up the original resolution of your highest res shot?
HIRAM
(Richard E Barber)
January 6, 2019, 10:48am
8
Also interested in seeing the file browser in hidpi. Please make a screenshot of it if you possibly can.
HIRAM
(Richard E Barber)
January 6, 2019, 10:52am
9
Yes. Retinex only works when editing raw image files. Looks like you are editing a jpeg, so the retinex tool should be disabled.
1 Like
Claes
January 6, 2019, 10:53am
10
Gladly – but I do not understand your wish, please rephrase it?!?
HIRAM
(Richard E Barber)
January 6, 2019, 10:56am
11
I noticed the screen shots have each been downsized to the same dimension 1475x756. Would you be able to post your shot of the 3840x2160 screen without downsizing?
Claes
January 6, 2019, 11:02am
12
Claes
January 6, 2019, 11:04am
13
I spotted that, too, and I am actually puzzled,
since I did not perform any downsizing… I used
Manjaro’s standard Screenshot app for the task.
I’ll investigate after lunch…
1 Like
Claes
January 6, 2019, 12:23pm
14
Patience, please…
I believe that I am on to something…
1 Like
Hombre
(Jean-Christophe)
January 6, 2019, 12:40pm
15
@HIRAM Thanks for this topic. Could you please add to the OP that test should be done with a TooWaBoo theme (“RawTherapee” theme is not updated for HiDPI). (ping @Claes )
1 Like
HIRAM
(Richard E Barber)
January 6, 2019, 12:43pm
17
Good things come to those who wait?
HIRAM
(Richard E Barber)
January 6, 2019, 12:46pm
18
Claes:
Oh, how cruel you are
My bad. Totally forgot that detail…
\color{red}\LARGEლ(ಠ益ಠლ)
Claes
January 6, 2019, 12:48pm
19
Ha!
a) Wrong red Heinz colour.
b) My present method (trying to preserve res) produces l-a-r-g-e files).
Pse PM me your e-mail addy so I can send you a zip or two.
1 Like
Hombre
(Jean-Christophe)
January 6, 2019, 12:50pm
20
( https://filebin.net/ accept large file )
1 Like