Local adjustments is in dev

strictly speaking it should be ‘rate of decay’ but it starts to get a bit long and the explanation in Rawpedia is clear.

This is where you just make up a fancy marketing term and let people guess at what it does… :wink:

3 Likes

Well, maybe that’s the way to get people to read Rawpedia! :wink:

I had noticed too, but I hadn’t connected it to the Local Adjustments tool. This seems a minor regression… @jdc, is there a translation string you have repurposed?

1 Like

Hello

I push a commit with:

  • change all labels and tooltip with weakening ==> decay (I choose the majority :slight_smile: )
  • suppress ‘f’ in Label “Dynamic Range compression” (main)…It was just a copy and paste… (this ‘f’ has the same meaning as in “Local adjustments” it indicates the use of the Fourier transform
  • change the order in which the tools appear in “add tool to current spot…”
  • change the default choice for “shadows Highlight” : Tone equalizer

Do you want to change other labels, or others tooltip ?

jacques

2 Likes

hello @jdc . By the way, it would be really great if you could port the whole Local tab in french !!! strangely all the software is in french at home, except the local tab !!!
I’m an Art user, but I like Nik’s U-points so much that I’m very interested in your work. Congratulations on the enormous amount of work you’ve done. :+1: :pray:

1 Like

@jllailes

I will try to do that

jacques

2 Likes

But, in french
Je vais faire cela progressivement par ordre alphabétique des items dans “default”

cela va prendre un peu de temps…il risque d’y avoir quelques incohérences…

jacques

I will merge a first “package” of translation…big job…many labels, many tooltips…(the same numbers as in english) :slight_smile:

jacques

1 Like

Thank you very much, Jacques. I think it will help francophones a lot. :+1: :pray:

@jllailes

I think I have finished…but there may be typos or spelling mistakes…

In french

C’est un gros travail…j’ai probablement fait des erreurs…Il a fallu aussi que certaines chaînes de caractère (labels) ne soient pas trop longues en français…ce qui a pour conséquence un “élargissement” du panel à droite…d’où un peu de mauvais langage…

Donc, si tu as des retouches…n’hésites pas

jacques

2 Likes

Bravo jacques, great job !

Si je vois des typos, je te les signale en Mp. :+1:

je viens de faire une série de retouches - typo - spelling - labels…qui étaient évidents

jacques

Been using local adjustments a bit more and have a few thoughts and suggestions. Some are repeats of what has already been said. These are all ui suggestions. I understand these take time and effort to implement and might be difficult or impossible to do. The basic use patter for me is to add shape, add tool, adjust shape transitions etc this is not currently the order of the interface.

  1. Make spot handling more in line with common ui patterns.
    • Use icons for spots, one icon for rectangle one for ellipse etc. (see ART masks)
    • Add spots by clicking on a location on the image after selecting spot type. Don’t place shape when icon is clicked.
    • Use one of the existing ui patterns for adding shapes. click drag diagonally to set size and location etc.
    • Darktable has a really nice feature where scrolling the mouse wheel changes the size of spots. This could be used for the central spot as well as the outer shape. This should be activated by hoover
    • Steal the shape creation stuff from ART
    • Allow outer shape and spot center to be manipulated independently. Allow dragging the spot whilst the outer shape stays in place.
    • Place spot nodes in the corners not in the middle of the line to allow quicker changes in shape.
  2. Reorder the ui according to workflow try to avoid scrolling up and down. I personally find that adjusting the affected area is a final fine tune. So the tool panels as ordered on your screen.
    • Break spot management out into it’s own panel located at the top. Reduce it to only include adding and removing spots. Remove sliders for spot size. Controll size only in viewport.
    • Place "Add tool to current spot immediately after the basic spot management tools.
    • Under the various added tools add a new panel for transitions, shape detection etc.

I find that adjusting transitions and shape detection are a last step that might not even be needed for simple adjustments. Hence the panels for this should come last. They also come with a high degree of complexity both in terms of concepts and ui. In addition the preview for instance doesn’t even work before you have added a tool. So having this above the “add tool” in the panels is a bit odd.

One non gui suggestion is to avoid terminology from other tools. The exposure tool appears to be quite different from the normal exposure for instance. Perhaps I’m misjudging but the effect seems different to me.

1 Like

hello jacques, i have reviewed all the tools in the local tab. The French localization looks very very good, I haven’t seen any typos or anything! :+1:

To pick up @nosle , I pretty much agree with his remarks. It’s clear that the tools available are very fine, rather complex (let’s say that a learning phase is really necessary by reading Rawpedia) but it seems that we have several possible ways to achieve similar results… this learning allows us to build our fastest workflow.
Regarding the U-points ergonomics, I do think that a simplification of the interface would greatly improve the tab. The layout should be as fast and user-friendly as possible. In use, I find that the way Nik handles this is rather ergonomic and user-friendly and sufficient: the circle with a left click and the size of the circle by swiping the trackpad or the mouse wheel. It’s fast and sufficient. I’m not convinced that another shape is really necessary with this method which is not a mask… the detection of the shapes or colors of the spot is powerful enough to avoid building a complex shape. The control of the transition of the edges of the circle is sufficient in my opinion.
Otherwise, @Hombre has indeed done a great job on Art in the shape mask. Maybe his work is transposable here? but I’m still rather seduced by Nik’s simple solution … the interest of a fast placement of the shapes is that we can place several of them easily to compensate for the fact that it is round, allowing transitions between the more natural shapes. it avoids thinking of the u-point (the Rt-spot) as a mask (even if we can associate a mask to it)
I mean, it’s just my opinion !

4 Likes

@jllailes @nosle
GUI improvements are already planned: I am currently working (slowly) on it. Progression can be followed here:

4 Likes

Thank you @Pandagrapher . I’ve just been compiling your branch :+1:

My TreeView works are in the LocallabGUI branch (not the newlocallab one). For the moments, it’s just functionality tests (name editing cell, for instance).

Ah, okay. Thank you.

I would like to point out 2 notable improvements made by @heckflosse Ingo and myself;
They relate to “exposure compensation” and “wavelet”

There are not more sliders or checkboxes

For “exposure compensation” we add a Laplacian just before “exposure”…
It will reduce the differences in luminance, for example on portraits and allow the use of “scope” in usual values…
Certainly not perfect, always prefer other tools for this use (Tone equalizer, TRC…), but it works…

For “wavelet” all tools had their cursor “Attenuation Response” which modulates the action according to the shape of the wavelet decomposition signal.
This “modulation” was a step pyramid which necessarily brings discontinuities.
Now this pyramid is continuous, so better results, more continuity.

Try these 2 improvements … without fleeing for fear of complexity …(Laplacian, Wavelets…)

jacques

4 Likes