Local Lab build

Software RawTherapee
793

With the new proposed layout, after creating a new spot, no adjustment will be attached to this new created spot. Thanks to a combobox widget, you will be able to add several different adjustments (from zero to all of them) to the selected spot (or remove them). Of course, if you add all the adjustments to a spot, you will have the current GUI behavior. The idea is to optimize the GUI to only show the adjustments you choose to use on a selected spot (and not having to find the tool in the middle of the 12 others)

Pierre

1 Like
794

Ah, thx! That really would make editing easier. As long as I can still temporarily disable a module to see its effect.

795

That makes sense…

796

Hello!, Found another crash:

  1. Open image
  2. Local Adjustements ON
  3. Add
  4. shape mode: Symmetrical (mouse+sliders)
  5. Right: 2
  6. Bottom: 2
  7. Color & Light - Small defects: red eyes, dust ON
  8. Move point of Color correction grid
    Crash

Version: 5.6-1191-g1becb76b7
Branch: newlocallab
Commit: 1becb76b7
Commit date: 2019-08-22
Compiler: x86_64-w64-mingw32-gcc\ 8.2.0
Processor: generic x86
System: Windows
Bit depth: 64 bits
Gtkmm: V3.24.1
Lensfun: V0.3.2.0
Build type: Release
Build flags: -mwin32\ -m64\ -mthreads\ -msse2\ -std=c++11\ -mtune=generic\ -Werror=unused-label\ -Wall\ -Wuninitialized\ -Wcast-qual\ -Wno-deprecated-declarations\ -Wno-unused-result\ -fopenmp\ -Werror=unknown-pragmas\ -Wno-aggressive-loop-optimizations\ -DNDEBUG\ -O3\ -ftree-vectorize
Link flags: -m64\ -mthreads\ -static-libgcc\ -mtune=generic\ -s\ -O3
OpenMP support: ON
MMAP support: ON

797

With the commit 78abb04 I hope the crash is solved :slight_smile:

jacques

1 Like
798

I added a “clarity and sharp mask” function in the “Local contrast / wavelet” module.

it’s the same approach as in the “wavelenh” branch, but simplified.

The selection between “sharp mask” and “clarity” is realized by the choice of “wavelet level”
If you choose level 2, 3, 4 ==> sharp mask
if you choose level 5, 6, 7, 8, 9 ==> clarity

I add a “guidedfilter” radius to reduce halos and too big gaps.

With use of scope and low levels, you can for example, “sharpen” as you want :slight_smile:

BTW : I have change (it’s code!) the manner to use “guidedfilter”, now instead of “L” (Lab), for “guid”, I use “Y” (XYZ). in fact “Y” is the same as “L” but without the gamma of 3, so linear

jacques

5 Likes
799

When can we expect a new build by @gaaned92?

800

@ChasingShadows :
You also have the Nightly Builds by Beep6581
But remember they are test builds.
Greetings .

1 Like
801

Thanks, I completely oversaw these …

802

@jdc Desmis :
I was waiting for the commit 78abb04 but I have not seen it…

However after install Version: 5.6-1207-ge8fbb58e0 Branch: newlocallab
and seems to fixed the problem. I think that the commit 78abb04 it has happened to me…
Thank you for fixing it.

A greeting

(g transl)

Edit:/ Found in 1207. Thank again, Desmis. Now it works fine.

commit 78abb0459291cb96c91d6287f73945b6451f6f48
Author: Desmis
Date: Sat Aug 24 20:32:48 2019 +0200
Fixed crash Color correction grid with very small spot

803

Hello again!. Found another crash:

1 Open image
2 Local Adjustements → ON
3 Settings-> Add

4 Local Contrast-> ON
5 ComboBox: Wavelet
6 ComboBox: Level local contrast-> Line
crash

Version: 5.6-1215-g5d2ca598d
Branch: newlocallab
Commit: 5d2ca598d
Commit date: 2019-09-02
Compiler: x86_64-w64-mingw32-gcc\ 8.2.0
Processor: generic x86
System: Windows
Bit depth: 64 bits
Gtkmm: V3.24.1
Lensfun: V0.3.2.0
Build type: Release
Build flags: -mwin32\ -m64\ -mthreads\ -msse2\ -std=c++11\ -mtune=generic\ -Werror=unused-label\ -Wall\ -Wuninitialized\ -Wcast-qual\ -Wno-deprecated-declarations\ -Wno-unused-result\ -fopenmp\ -Werror=unknown-pragmas\ -Wno-aggressive-loop-optimizations\ -DNDEBUG\ -O3\ -ftree-vectorize
Link flags: -m64\ -mthreads\ -static-libgcc\ -mtune=generic\ -s\ -O3
OpenMP support: ON
MMAP support: ON

804

@arturoisilvia

Hello
Thank you for testing… and find a bug :slight_smile:

I just fixed it (I hope) in commit 9d8aa5e

Jacques

805

@jdc
Tested commit 9d8aa5e
It works fine.
Thanks. Great job.

806

Hello!, Found another crash almost in the same place as the first:

1 Open image
2 Local Adjustements ON
3 Add
4 shape mode: Symmetrical (mouse+sliders)
5 Right: 2
6 Bottom: 2
7 Color & Light - Small defects: red eyes, dust ON
8 Lightness: -100
Crash

Version: 5.7-992-gfc7f55e54
Branch: newlocallab
Commit: fc7f55e54
Commit date: 2019-09-11
Compiler: x86_64-w64-mingw32-gcc\ 8.2.0
Processor: generic x86
System: Windows
Bit depth: 64 bits
Gtkmm: V3.24.1
Lensfun: V0.3.2.0
Build type: Release
Build flags: -mwin32\ -m64\ -mthreads\ -msse2\ -std=c++11\ -mtune=generic\ -Werror=unused-label\ -Wall\ -Wuninitialized\ -Wcast-qual\ -Wno-deprecated-declarations\ -Wno-unused-result\ -fopenmp\ -Werror=unknown-pragmas\ -Wno-aggressive-loop-optimizations\ -DNDEBUG\ -O3\ -ftree-vectorize
Link flags: -m64\ -mthreads\ -static-libgcc\ -mtune=generic\ -s\ -O3
OpenMP support: ON
MMAP support: ON

807

Reproduced on Linux.
If Right and Bottom > 2, no crash.

As a side note, I wonder if it’s necessary to keep those (mouse+sliders) modes.

1 Like
808

@arturoisilvia @sguyader

Thank you for testing

I think the crash is fixed (commit a22624e), in this case and in 7 others cases where Rt-spot was too small to do calculation.

I think the change will not affect the use

jacques

809

Just a probably OT question: I installed this file on my external HDD:

RawTherapee_newlocallab_5.7-1007-g221fb337b_WinVista_64

Source: RTW64NightlyBuilds/ – Keybase.pub

It works fine, but I thought there was a Clarity function/slider. Is that still there? Seems I can’t find it.

810

@st.raw

You can find “clarity” in 2 modules -

  1. in “Local contrast” - “Wavelet” - Sharp Mask and Clarity - for level wavelet you want ( for levels from 5 to maximum) - sharp mask is enabled between levels 1 to 4.

  2. in “Contrast by detail level” - Residual image - for only “one” configuration (5 levels) - Sharp Mask is not possible

jacques

1 Like
811

Are we talking the same Dev version? RawTherapee_newlocallab_5.7-1007-g221fb337b_WinVista_64 ?

Here is what this version for me has under “Local contrast” and “Contrast by detail level” :

27
271920×1080 1.67 MB

812

@st.raw

Yes, it is this version, but you must use “Local” - “Local adjustements”

jacques