Tried to raise the scope , helped just a little. Highlight compression helped - but prevented lifting of the shadows.
Using the Shadows/Highlights did give a much better result as shown below
Using the Exposure in local adjustment is giving me strange result with many pictures. Can’t figure out , how to use it. It’s just confusing me.
@Dxouser For some reason, I found placing the spot on the wall behind, then raising exposure by 2 stops and drawing S shaped curve seemed to work. Also made rectangular shape over cab and raised exposure by 1.7 stops.
Here is the pp3
Playraw_spidermonkey.NEF.pp3 (24.2 KB)
Looks OK to me, but not as good as some other people’s
Since one mounth I introduced several improvments
Original retinex with “Laplace transformed - Fourier transformed - Poisson PDE” which in some cases can replace “Dodge and burn”
Similar function as above, add to “Exposure”, which improves the results in difficult cases (pronounced shadows …)
Normalize luminance for Retinex and Tone-mapping. if checked “Luminance” result as the same “mean” and same “standard deviation” as original
Add a method to “Local contrast” with “Simple Wavelet” (same algo as in Wavelet “Final touchup - final local contrast”
Add 2 methods in “Blur and noise” : median (same are used in Denoise), and Guided filter
Add mask to “Tone mapping”, and “Blur and noise”
add mask in inverse mode for “Color and Light”, “Exposure”, “Shadows Highlight”, “Blur and Noise” with certain limitations (do not show modifications)
…
jacques
The version newlocallab 5.6-1144-gd39eded26 crashes, when you want to paste or save a partial pp3. This does not happen with version dev 5.6-219-g972d6907d.
Concerning the GUI: Can the spot management be implemented with inline editing/buttons in the table? Replace the big “status” column with a slim one containing just an Icon, e.g. an eye or glasses, that can be pushed to toggle visibility.
Double click on the name field opens a line editor to change the name in-place.
What also would be awesome: allow enabling/disabling a spot. Another small column with an icon for each spot could handle that.
That way we can get rid of two buttons (Rename and Show/Hide) and get a full line space saved and gain space for the “Name” column. And Showing/Hiding/Renaming requires less work, especially when going over several spots.
Regarding the GUI. I would love to be able to select an area with more precision using something like a lasso tool. It is hard to do it with the elipse/rectangle.
Something like this:
This crash has been solved under Github
Pierre
Hello All,
For your information, I have started a new session of improvements of Locallab GUI.
You can follow what is planned and the progression here:
@ff2000
Thanks for the suggestion: I was also thinking about implementing kinda the same, or maybe adding some right-click menu on spot list, idk… I will see when I will be working on this code part.
Pierre
Thank you
Just to clarify my understanding of the new proposed interface. With the current set up it is possible to select an area with a spot then apply many different adjustments (eg tone curve, local contrast) to it. With the new proposed layout would it be necessary to create a new spot for each adjustment made? Perhaps I have misunderstood it. Thanks.
With the new proposed layout, after creating a new spot, no adjustment will be attached to this new created spot. Thanks to a combobox widget, you will be able to add several different adjustments (from zero to all of them) to the selected spot (or remove them). Of course, if you add all the adjustments to a spot, you will have the current GUI behavior. The idea is to optimize the GUI to only show the adjustments you choose to use on a selected spot (and not having to find the tool in the middle of the 12 others)
Pierre
Ah, thx! That really would make editing easier. As long as I can still temporarily disable a module to see its effect.
That makes sense…
Hello!, Found another crash:
Version: 5.6-1191-g1becb76b7
Branch: newlocallab
Commit: 1becb76b7
Commit date: 2019-08-22
Compiler: x86_64-w64-mingw32-gcc\ 8.2.0
Processor: generic x86
System: Windows
Bit depth: 64 bits
Gtkmm: V3.24.1
Lensfun: V0.3.2.0
Build type: Release
Build flags: -mwin32\ -m64\ -mthreads\ -msse2\ -std=c++11\ -mtune=generic\ -Werror=unused-label\ -Wall\ -Wuninitialized\ -Wcast-qual\ -Wno-deprecated-declarations\ -Wno-unused-result\ -fopenmp\ -Werror=unknown-pragmas\ -Wno-aggressive-loop-optimizations\ -DNDEBUG\ -O3\ -ftree-vectorize
Link flags: -m64\ -mthreads\ -static-libgcc\ -mtune=generic\ -s\ -O3
OpenMP support: ON
MMAP support: ON
With the commit 78abb04 I hope the crash is solved 
jacques
I added a “clarity and sharp mask” function in the “Local contrast / wavelet” module.
it’s the same approach as in the “wavelenh” branch, but simplified.
The selection between “sharp mask” and “clarity” is realized by the choice of “wavelet level”
If you choose level 2, 3, 4 ==> sharp mask
if you choose level 5, 6, 7, 8, 9 ==> clarity
I add a “guidedfilter” radius to reduce halos and too big gaps.
With use of scope and low levels, you can for example, “sharpen” as you want
BTW : I have change (it’s code!) the manner to use “guidedfilter”, now instead of “L” (Lab), for “guid”, I use “Y” (XYZ). in fact “Y” is the same as “L” but without the gamma of 3, so linear
jacques
@ChasingShadows :
You also have the Nightly Builds by Beep6581
But remember they are test builds.
Greetings .
Thanks, I completely oversaw these …
