R&Darktable with early phase Color Eq module ...

priort · June 22, 2022, 10:56pm

Windows build with Color Eq…just introduced and a WIP…

mikae1 · June 23, 2022, 5:27am

Oh, color equalizer? This makes me very interested. I’m on Linux so can’t try. Could you provide some screenshots?

Aliks · June 23, 2022, 8:26am

What?? I just downloaded and compiled R&Darktable this morning on my Linux desktop and the Color Equalizer is not there.

The version number is showing as 60bbf83

What’s up??

nipsi · June 23, 2022, 10:22am

color equalizer seems to still be in it’s own branch and is not merged with master:

anon41087856 · June 23, 2022, 12:11pm

I have explained stuff here:

Aliks · June 23, 2022, 1:42pm

Thanks Aurelian, I can now compile from the dev option and see the color equalizer module.

anon16817310 · June 23, 2022, 1:53pm

Is this what I think it is? Suggestion to improve the Color balance RGB module · Issue #10474 · darktable-org/darktable · GitHub ?

priort · June 23, 2022, 2:18pm

Explained here…

github.com/darktable-org/darktable

[WIP] Add new module : color EQ(ualizer)

darktable-org:master ← aurelienpierre:color-EQ

opened 08:03PM - 21 Jun 22 UTC

aurelienpierre

+1389 -153

This is essentially a rewrite of the color zones module, in a way compatible wit…h HDR signals (unbounded RGB, but **not** scene-referred since we do color work). It uses the [darktable UCS 22](https://eng.aurelienpierre.com/2022/02/color-saturation-control-for-the-21th-century/) color space, namely the hue-saturation-brightness space that accounts for Helmholtz-Kohlrausch effect. The interpolation of hue nodes uses a [periodic RBF](https://eng.aurelienpierre.com/2022/06/interpolating-hue-angles/) that ensures infinitely smooth connection of the curve throughout the hue ring. It re-uses the internal gamut-mapping of color balance RGB so color changes will not push colors outside of the working space gamut. The graph background gradients are cached and generated only when required for improved performance. All the GUI colors (sliders and graph background) are color-managed and gamut-mapped against display color space. **Warning: since the display profile is published in the pipeline, and the GUI widgets are inited before the pipeline, the colors are inited in sRGB and updated to display RGB after the first user interaction with the controls. Expect a slight change in saturation when you first interact with the sliders.** The graphs are (at least for now) read-only, and all interaction happens in sliders. Not sure if it's worth the overhead to make the graphs draggable, Gtk redraws are already killing UI responsiveness. The 8 color nodes are fixed in number and position. This makes it possible to map them to things like that through MIDI: ![image](https://user-images.githubusercontent.com/2779157/174887218-fe263f7a-eb74-4139-8096-7382a8927962.png) Also it simplifies both the UI and the usability. Keep in mind that hue-wise color changes are difficult to blend due to the non-linearity of angles (duh…), so the corrections should be gentle and smooth. TODO: add a guided filter to ensure color changes are contiguous in the picture and avoid creating chroma noise. ![Screenshot_20220621_220227](https://user-images.githubusercontent.com/2779157/174887668-78955299-e1a7-4f9d-af20-09c5091b7435.png) ![Screenshot_20220621_220208](https://user-images.githubusercontent.com/2779157/174887673-e5e6de62-3df5-4a11-bcf1-c7c3f3da67bc.png) ![Screenshot_20220621_220153](https://user-images.githubusercontent.com/2779157/174887677-c588c5f2-90fc-4d63-b970-5be39750730a.png)

priort · June 23, 2022, 2:20pm

Correct…

priort · June 23, 2022, 2:22pm

See the PR link I posted…

RawConvert · June 23, 2022, 3:27pm

@anon41087856 , nice to see things happening.
How do you want possible bugs and feature suggestions communicated pls?

mikae1 · June 23, 2022, 3:33pm

Oh, didn’t know about these plans. This is making me very excited. Good timing because the last weeks I’ve been trying to leave the 3d lut module behind and grade with color balance rgb. However, because of the ineffectiveness of jumping between multiple modules with (with parametric masks) I gave up and went back to a single instance of 3d lut at the end of my pipeline.

anon41087856 · June 23, 2022, 3:36pm

Right, I completely forgot this issue, but essentially, yes.

anon41087856 · June 23, 2022, 3:37pm

On Github please, using issue tracker.

RawConvert · June 23, 2022, 3:46pm

I can’t see anything on your R&D… github, so I assume use the standard dt tracker.

anon41087856 · June 23, 2022, 3:48pm

Right, forgot to enable it. Anything related to pixel pipeline will anyway affect both projects. Stuff related to GUI changes made on R&Dt obviously belongs to R&Dt.

anon16817310 · June 23, 2022, 4:07pm

Right on! Thanks for tackling this issue!

anon16817310 · June 27, 2022, 2:05pm

I compiled the latest R&Darktable, and I just want to say well done on the Color Equalizer module @anon41087856 ! I already find it easier to use than color zones, and look forward to the guided filter feature. I wonder about the hue tab sliders, though. Wouldn’t it be easier to use if you restricted the hue shift up to the next node (45º in each direction) instead of the full 360º rotation? I’d say that would probably be the most common usecase, and if you wanted something extreme, you can always right click and type in the value.

priort · June 27, 2022, 2:43pm

Did you build from Color-eq or dev branch… I tried from the dev branch as it had one newer commit than Color-eq but it did not build for me…complained about something related to colorbalance rgb…just wondering. I asked AP on git but he has been busy I am sure …

anon16817310 · June 27, 2022, 4:28pm

I built it from the dev branch, but made sure to delete my older compiled version of R&D following @kofa 's advice: