heckflosse
(Ingo Weyrich)
September 20, 2019, 6:52pm
7
@hanatos showed me the Waveform histogram at lgm 2019, and it’s really cool. Maybe we can steal the code
2 Likes
heckflosse
(Ingo Weyrich)
September 20, 2019, 7:37pm
9
Well, that balances over the time
afre
(Alan)
September 20, 2019, 8:02pm
11
Representing all Canadians.
dafrasaga
(Gabriele )
September 21, 2019, 4:27am
12
Ok, I know it… in fact it was obscure because waveform histogram in post production would done useful for ETTR.
dafrasaga
(Gabriele )
September 21, 2019, 4:34am
13
In RT , when I want to know where is clipping I use, as you, the clipping indicator and for what channel is clipped the preview channel button at the top of the preview window…therefore… what is the utility of the waveform histogram for that… ?
dafrasaga
(Gabriele )
September 21, 2019, 5:08am
15
Thanks for the information
hanatos
(jo)
September 23, 2019, 7:19am
16
heckflosse:
steal the code
i doubt you need to steal these two lines of code. probably faster to type your own version than to copy/paste + fixup… :
const dt_iop_order_iccprofile_info_t *const profile =
dt_ioppr_get_pipe_current_profile_info(module, piece->pipe);
dt_color_picker_helper(dsc, pixel, &roi_copy, box,
darktable.lib->proxy.colorpicker.primary_sample->denoise,
pick, image_cst,
dt_iop_color_picker_get_active_cst(module), profile);
for_four_channels(k)
{
picked_color_min[k] = pick[DT_PICK_MIN][k];
picked_color_max[k] = pick[DT_PICK_MAX][k];
picked_color[k] = pick[DT_PICK_MEAN][k];
}
error:
dt_free_align(tmpbuf);
}
#endif
/*
This file is part of darktable,
Copyright (C) 2011-2023 darktable developers.
darktable is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
darktable is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with darktable. If not, see <http://www.gnu.org/licenses/>.
*/
#include <stdint.h>
This file has been truncated. show original
2 Likes
dafrasaga
(Gabriele )
October 24, 2020, 5:09am
17
WOW!! waveform is in dev @Lawrence37 Thanks a lot !!
4 Likes
Sunhillow
(Hansgeorg)
October 25, 2020, 3:46pm
18
Now my task will be to understand what it indicates
1 Like
heckflosse
(Ingo Weyrich)
October 25, 2020, 3:53pm
19
The horizontal axis in the waveform histogram corresponds to the horiziontal axis of your image. Means you can see where for example highlights are clipped
3 Likes
Sunhillow
(Hansgeorg)
October 25, 2020, 3:58pm
20
Thanks! Now as you say it … I also had a look at the video linked a bit above. So the white bar on top indicates “all channels clipped”.
And big thanks for implementing all kind of useful tools!
heckflosse
(Ingo Weyrich)
October 25, 2020, 4:00pm
21
Don’t thank me, thank @Lawrence37 , who implemented waveform and vectorscope for RT and he’s the one who can give you better answers for this than me.
mbs
(Miguel B)
October 25, 2020, 4:19pm
22
This is a good explanation: How to Use and Read the Four Primary Video Scopes
I just compiled the latest dev, and the new scopes seem to be working great. These are very useful tools, thanks @Lawrence37 !
1 Like
ggbutcher
(Glenn Butcher)
October 25, 2020, 4:19pm
23
Oh, but you’re the first one to provide an explanation that made sense to me…
2 Likes
Sunhillow
(Hansgeorg)
October 25, 2020, 4:23pm
24
Of course, @Lawrence37 ! Great work
(and one of @heckflosse ’s latest merits were earned with the excellent capture sharpening tool)
heckflosse
(Ingo Weyrich)
November 1, 2020, 9:44pm
26
Have a look at the latest video from Andy. Very good!
7 Likes