Wavelets Module in Mac Release and Dev

[Andy_Astbury1 (Andy Astbury)]

Is it me, missing something, or is something broken?

If I make contrast adjustments for instance, the selective luminance sliders do not seem to function, and the image at 100% view looks like I have whole luminance range selected.

Currently running:

Version: 5.10-194-g95f85d50f
Branch: dev
Commit: 95f85d50f
Commit date: 2024-04-24
Compiler: clang 15.0.0.15000309
Processor: arm64
System: Apple
Bit depth: 64 bits
Gtkmm: V3.24.9
Lensfun: V0.3.4.0
Build type: Release
Build flags: -std=c++11 -mcpu=native -Werror=unused-label -Werror=delete-incomplete -fno-math-errno -Wno-attributes -mmacosx-version-min=13.3 -flto -Wall -Wuninitialized -Wcast-qual -Wno-deprecated-declarations -Wno-unused-result -Wunused-macros -Xpreprocessor -fopenmp /opt/homebrew/lib/libomp.dylib -I/opt/homebrew/include -Werror=unknown-pragmas -O3 -DNDEBUG=1 -I/opt/homebrew/include -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk/usr/include -Wno-pass-failed -arch arm64 -Wno-deprecated-register -Wno-unused-command-line-argument -std=c++11 -ftree-vectorize
Link flags: -L/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk/usr/lib -Wl,-headerpad_max_install_names -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk -arch arm64 -mcpu=native -Wl,-headerpad_max_install_names -mtune=generic -framework Foundation -flto
OpenMP support: ON
MMAP support: ON
Build OS: Darwin 23.4.0 arm64
Build date: Sat, 27 Apr 2024 00:56:30 +0000 UTC
Build epoch: 1714179390
Build UUID: 17681ff3-0159-4913-bef3-f205093e28fb

---

Bundle system: Apple M1
Bundle OS: macOS 14.4.1 23E224 Darwin 23.4.0 arm64
Bundle date: Sat, 27 Apr 2024 00:59:23 +0000 UTC
Bundle epoch: 1714179563
Bundle UUID: c3b5291b-a0da-4e52-95e6-adce33d7760c

=====================================

Version: 5.10-194-g95f85d50f
Branch: dev

But the problem also appears in the release:
Version: 5.10
Branch: 5.10
Commit: 8adb5439d
Commit date: 2024-02-15
Compiler: clang 15.0.0.15000100
Processor: arm64
System: Apple
Bit depth: 64 bits
Gtkmm: V3.24.8
Lensfun: V0.3.4.0
Build type: Release
Build flags: -std=c++11 -mcpu=native -Werror=unused-label -Werror=delete-incomplete -fno-math-errno -Wno-attributes -mmacosx-version-min=13.3 -flto -Wall -Wuninitialized -Wcast-qual -Wno-deprecated-declarations -Wno-unused-result -Wunused-macros -Xpreprocessor -fopenmp /opt/homebrew/lib/libomp.dylib -I/opt/homebrew/include -Werror=unknown-pragmas -O3 -DNDEBUG=1 -I/opt/homebrew/include -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk/usr/include -Wno-pass-failed -arch arm64 -Wno-deprecated-register -Wno-unused-command-line-argument -std=c++11 -ftree-vectorize
Link flags: -L/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk/usr/lib -Wl,-headerpad_max_install_names -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk -arch arm64 -mcpu=native -Wl,-headerpad_max_install_names -mtune=generic -framework Foundation -flto
OpenMP support: ON
MMAP support: ON
Build OS: Darwin 22.6.0 arm64
Build date: Sun, 25 Feb 2024 06:39:47 +0000 UTC
Build epoch: 1708843187
Build UUID: a6cd9b9e-5bcd-4557-9e86-8895ebf0a4ea

---

Bundle system: Apple M1
Bundle OS: macOS 13.6.3 22G436 Darwin 22.6.0 arm64
Bundle date: Sun, 25 Feb 2024 08:46:44 +0000 UTC
Bundle epoch: 1708850804
Bundle UUID: 2c35cb4d-ef89-49c2-86d3-ac2aca58733c

=====================================

Version: 5.10
Branch: 5.10
Commit: 8adb5439d
Commit date: 2024-02-15
Compiler: clang 13.0.0.13000029
Processor: nehalem-westemere
System: Apple
Bit depth: 64 bits
Gtkmm: V3.24.8
Lensfun: V0.3.4.0
Build type: Release
Build flags: -std=c++11 -Werror=unused-label -Werror=delete-incomplete -fno-math-errno -Wno-attributes -mmacosx-version-min=11.3 -flto -Wall -Wuninitialized -Wcast-qual -Wno-deprecated-declarations -Wno-unused-result -Wunused-macros -Xpreprocessor -fopenmp /usr/local/opt/libomp/lib/libomp.dylib -I/usr/local/opt/libomp/include -Werror=unknown-pragmas -I/usr/local/include -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/include -Wno-pass-failed -Wno-deprecated-register -Wno-unused-command-line-argument -std=c++11 -DNDEBUG=1 -O3 -ftree-vectorize
Link flags: -L/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/lib -Wl,-undefined,dynamic_lookup -Wl,-headerpad_max_install_names -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -O3 -DNDEBUG=1 -Wl,-headerpad_max_install_names -mtune=generic -framework Foundation -flto
OpenMP support: ON
MMAP support: ON
Build OS: Darwin 20.6.0 x86_64
Build date: Sun, 25 Feb 2024 06:10:51 +0000 UTC
Build epoch: 1708841451
Build UUID: 8b0e2c27-cb8e-41f7-80ad-b978757de7de

---

Bundle system: Intel(R) Xeon(R) CPU E5-4627 v2 @ 3.30GHz
Bundle OS: macOS 11.7.10 20G1427 Darwin 20.6.0 x86_64
Bundle date: Sun, 25 Feb 2024 06:17:36 +0000 UTC
Bundle epoch: 1708841856
Bundle UUID: 54b914d3-0f84-4999-8b2a-752a9764ae12

[HIRAM (Richard E Barber)]

RawTherapee Wavelets

I have RawTherapee on W11. In the advanced Tab is Wavelets. In the Contrast part, at bottom, is ‘Selective Luminance Range’, & further down is ‘Chroma’. Both don’t work. Still. And a colleague using dev build says the same. Anyone know why and if they will get fixed?? I’m writing here 'cos I just don’t know how to make a bug report.

Appears broken. Will have to be GitHub reported at some point.

[jdc (Desmis)]

@Andy_Astbury1

Indeed there is a malfunction for the “selective range” part.
I haven’t touched this code in several years. So probably an interaction with other code that uses wavelets - probably at the level of “Local adjustments”.
I’ll see what I can do.

Thank you

Jacques

[jdc (Desmis)]

@Andy_Astbury1

I found where the malfunction comes from. It’s just an oversight.
I check and make a pull-request

Jacques

[jdc (Desmis)]

I just create a Pull-request
https://github.com/Beep6581/RawTherapee/pull/7070

Executable
Exec wav_select

Jacques

[Andy_Astbury1 (Andy Astbury)]

Funny thing, I find RT wavelets easier than DTs’ - and I’m 64!

If at all possible, I think there’s also a really epic thing happened in the Abstract Profile section of the dev build - that mid tone slider. That needs sticking in the public build asap if you ask me, and massive congrats to who put it in there…

[jdc (Desmis)]

@Andy_Astbury1

I’m almost 13 years older than you…but you can’t say I’m in top form.
The one who put the “mid tones” is not a stranger… It’s me

jacques

[Andy_Astbury1 (Andy Astbury)]

I knew it would be you Boss!

[Andy_Astbury1 (Andy Astbury)]

Can a Mac build be done to fix this problem please, otherwise I’ll feel left out!

[jdc (Desmis)]

@Andy_Astbury1
I have no way of producing a Mac version. The most likely solution is to wait until I “merge” this PR, then someone makes a Mac version.
I think the malfunction is corrected.

Jacques

[jdc (Desmis)]

@Andy_Astbury1
I just merge the pull-request in dev

Jacques