Test RawTherapee 5.6-rc1

I was just looking up what’s new in 5.6, here’s the list…

"New features since 5.5:

  • HiDPI support, for a smooth and sharp user interface regardless of screen size. Scaling in RawTherapee depends on font size, DPI and display scaling. No scaling occurs when the font size is set to 9pt, DPI is set to 96 (or 72 for macOS) and scaling is set to 1 (100%).

  • Ability to move tools to a new Favorites tab, Favorites Tab - RawPedia

  • “Unclipped” processing profile, to make it easy to save an image while preserving data across the whole tonal range, Unclipped - RawPedia

  • User-adjustable tiles-per-thread settings in Preferences > Performance, for users who want to perform performance benchmarks to find optimal values for their system. The default value of 2 tiles-per-thread performs best overall.

  • Hundreds of speed optimizations, bug fixes, and overall improvements.

(from here - RawTherapee/RELEASE_NOTES.txt at 5.6-rc1 · Beep6581/RawTherapee · GitHub)

++++ Thanks developer folks ++++

3 Likes

It looks like the button size and spacing is to much for most users.
I can try to make the buttons and spacing a bit smaller on the weekend for the RT- and TWB-theme.

3 Likes

Working fine on Win10 64.

Sorry, now that i know what is padding, even in the 5.6rc1 appimage they were just as big.

I attach a pair of screenshots.

5.6 appimage rc1

5.6 icon-size-fix branch

Also compared to 5.5 there is some vertical space lost on the top of the window.

For reference, RawTherapee 5.5:

RawTherapee 5.6 (font size 9, 96DPI):

@Hombre - unfortunately I don’t have a working build environement for RawTherapee at the moment. If someone could make a build of the icon-size-fix branch for macOS available, I’d be happy to try it.

rc1 seems to be built with GTK 3.24.1:


Version: 5.6-rc1
Branch: 5.6-rc1
Commit: e1c8f3a86
Commit date: 2019-04-10
Compiler: clang 10.0.1.10010046
Processor: generic x86
System: Apple
Bit depth: 64 bits
Gtkmm: V3.24.1
Lensfun: V0.3.95.0
Build type: release
Build flags: -std=c++11 -std=c++11 -mtune=generic -Werror=unused-label -mmacosx-version-min=10.9 -flto -Wall -Wuninitialized -Wno-deprecated-declarations -Wno-unused-result -Xpreprocessor -fopenmp /opt/local/lib/libiomp5.dylib -I/opt/local/include -Werror=unknown-pragmas -O3 -DNDEBUG -ftree-vectorize
Link flags:  -mtune=generic -headerpad_max_install_names -flto
OpenMP support: ON
MMAP support: ON

Running rc1 with verbose=true produces a lot of output, the only bit I can see relevant to UI layout is:

"Non-Default" font size(9) * scale(1) / fontScale(1.000)
CSS:
* { font-family: Helvetica Regular; font-size: 9pt}


(rawtherapee-bin:34747): GLib-GObject-WARNING **: 12:37:51.560: invalid cast from 'GtkMenuBar' to 'GtkWindow'

(rawtherapee-bin:34747): GLib-GObject-WARNING **: 12:37:51.581: invalid (NULL) pointer instance

(rawtherapee-bin:34747): GLib-GObject-CRITICAL **: 12:37:51.581: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed

(rawtherapee-bin:34747): GLib-GObject-WARNING **: 12:37:51.581: invalid (NULL) pointer instance

(rawtherapee-bin:34747): GLib-GObject-CRITICAL **: 12:37:51.581: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed

(rawtherapee-bin:34747): GLib-GObject-WARNING **: 12:37:51.982: invalid (NULL) pointer instance

(rawtherapee-bin:34747): GLib-GObject-CRITICAL **: 12:37:51.982: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed

(rawtherapee-bin:34747): GLib-GObject-WARNING **: 12:37:51.982: invalid (NULL) pointer instance

There are a lot of glib assert failures, but there always have been on the mac version, so they’re probably harmless.

I will build the test branch momentarily for mac…

Actually 5.6rc1 is built with gtk3.24.7, gtkmm is a different library.

@paulmiller Here is a mac build of the current icon-size-fix branch:
https://kd6kxr.keybase.pub/RawTherapee_OSX_10.9_64_5.5-292-gd01d99481.zip

1 Like

In this screenshot you can compare the difference on plain 1080p between icon-size-fix and 5.6rc1 for macOS 10.14.5ß18F108f :


One thing I noticed on icon-size-fix was I had to change my font size from 11 to 18, and the text became much crisper.

1 Like

Tried it, the text got smaller but the icons stayed the same size:

1 Like

As I need to make a decision regarding the release of RawTherapee 5.6, I have questions:

  1. Is it possible to get the unpatched 5.6-rc1 build to look good (icons and text at a decent size) in macOS 10.14? If so, how?
  2. Does the issue with icons being too large compared to the text happen only in macOS 10.14, or also in other versions of macOS and other operating systems?

Which version of macOS?
To me, 5.6-rc1 looks correct, and icon-size-fix looks wrong. Is that what you’re implying?

Note to everyone: please be explicit and provide details regarding which OS and version you’re testing or what you’re showing in screenshots. Don’t leave things up to guesswork.

These are on macOS 10.14.5ß18F108f. I think the rc1 looks fine on 1080p, icons being large in icon-size-fix. I suppose there is more to do with icon size/padding and mac resolution, @Hombre. I got the impression that there was a problem using the Retina display (4K/5K etc) on mac laptops and those monitors in general. The command system_profiler SPDisplaysDataType will output the info about the GPUs and displays. So for those with a Retina display, that would be indicated, where mine below says 1080p. Maybe the program could take advantage of that info?

$ system_profiler SPDisplaysDataType
Graphics/Displays:

    AMD FirePro D300:

      Chipset Model: AMD FirePro D300
      Type: GPU
      Bus: PCIe
      Slot: Slot-1
      PCIe Lane Width: x16
      VRAM (Total): 2 GB
      Vendor: AMD (0x1002)
      Device ID: 0x6810
      Revision ID: 0x0000
      ROM Revision: 113-C4012F-687
      VBIOS Version: 113-C4012PA-012
      EFI Driver Version: 01.0D.687
      Automatic Graphics Switching: Supported
      gMux Version: 4.0.11 [3.2.8]
      Metal: Supported, feature set macOS GPUFamily2 v1

    AMD FirePro D300:

      Chipset Model: AMD FirePro D300
      Type: GPU
      Bus: PCIe
      Slot: Slot-2
      PCIe Lane Width: x16
      VRAM (Total): 2 GB
      Vendor: AMD (0x1002)
      Device ID: 0x6810
      Revision ID: 0x0000
      ROM Revision: 113-C4012F-687
      VBIOS Version: 113-C4012PB-012
      EFI Driver Version: 01.0D.687
      Automatic Graphics Switching: Supported
      gMux Version: 4.0.11 [3.2.8]
      Metal: Supported, feature set macOS GPUFamily2 v1
      Displays:
        HP 2310:
          Resolution: 1920 x 1080 (1080p FHD - Full High Definition)
          UI Looks like: 1920 x 1080 @ 50 Hz
          Framebuffer Depth: 30-Bit Color (ARGB2101010)
          Display Serial Number: 3CQ0165ZXM  
          Main Display: Yes
          Mirror: Off
          Online: Yes
          Rotation: Supported
          Automatically Adjust Brightness: No

I get:

system_profiler SPDisplaysDataType
Graphics/Displays:

    Radeon Pro 560X:

      Chipset Model: Radeon Pro 560X
      Type: GPU
      Bus: PCIe
      PCIe Lane Width: x8
      VRAM (Total): 4 GB
      Vendor: AMD (0x1002)
      Device ID: 0x67ef
      Revision ID: 0x00c2
      ROM Revision: 113-C980AL-075
      VBIOS Version: 113-C97501U-005
      EFI Driver Version: 01.01.075
      Automatic Graphics Switching: Supported
      gMux Version: 5.0.0
      Metal: Supported, feature set macOS GPUFamily2 v1
      Displays:
        Color LCD:
          Display Type: Built-In Retina LCD
          Resolution: 2880 x 1800 Retina
          Framebuffer Depth: 24-Bit Color (ARGB8888)
          Main Display: Yes
          Mirror: Off
          Online: Yes
          Rotation: Supported
          Automatically Adjust Brightness: No

    Intel UHD Graphics 630:

      Chipset Model: Intel UHD Graphics 630
      Type: GPU
      Bus: Built-In
      VRAM (Dynamic, Max): 1536 MB
      Vendor: Intel
      Device ID: 0x3e9b
      Revision ID: 0x0000
      Automatic Graphics Switching: Supported
      gMux Version: 5.0.0
      Metal: Supported, feature set macOS GPUFamily2 v1

On my mac (its a retina MacBook Pro). macOS version is Mojave 10.14.4. system_profiler doesn’t tell you, but the display is scaled to look like 1680x1050 (according to the Displays System Preferences panel).
According to Cocoa, the backingScaleFactor for this display is 2.0 and the display frame is 1680x1050

Thanks for sharing this Morgan…is there a release notes document somewhere that details what is different between 5.5 and 5.6…

Thanks

Did you do a restart of RT when changing the font size or dpi?

Yes.

When I change the main font size, it gets much bigger and then shrinks again after I quit/relaunch RT. After relaunching RawTherapee, the text size in the user interface is correct (i.e. 9 point text is the same size as 9 point text in native mac applications), but the icons look too big. Immediately after you change the text size in the RawTherapee preferences, it is much bigger.

Here is a screen shot of the preferences window before and after changing the main font size from 9 to 10 and then back to 9 again, without restarting RawTherapee:

Notice that the font ends up approximately 2x too big.

If I restart RawTherapee, it returns to the ‘before’ size.

I guess the icons are about 2x too large when running on a Retina display on macos.

When I change between the various display scaling modes available on macos, the RawTherapee UI keeps the same relative proportion of text and icons, it just gets bigger or smaller.

This is with the 5.5-292-gd01d99481 version.

Thanks for this test. I’m trying to solve this issue with the help of @HIRAM .

Just had a save warning in 5.6 RC1. Was saving a DNG from the other thread about wrong colours (overexposed highlights and recovered details but pink sky - posted by dsdsd) as a TIFF which saved fine but got this console warning.