I don’t know, you can argue for both alternatives. The solution I implemented was simply the cheapest code-wise (meaning that it had the smallest impact on the code), unless there’s a strong argument to change it, I’d say it stays that way.
In fact, if you want a “hard-coded” prefix defined at execution time, I think we can get rid of the options completely and simply fix the path in the executable…
@noteasy2beme Perhaps can you try
-DCMAKE_INSTALL_DATAROOTDIR=/what/you/want
@agriggio for me, it is ok as it is.
Only my opinion: the hard coding (as for LCP or DCP) is perhaps the best way to avoid future problems (mainly on windows). Should it be applicable also on Linux?
Presently, I cannot really say we can generate a portable version of rawtherapee as explained in Rawpedia. In fact, except the cache and option file, the config folder remains external to the RT directory.
Thus when you copy RT on a USB key and go on an other computer you miss the dynamicprofile.cfg, the profiles dir and batch dir. But nobody seems to worry about that, included me. @partha was able, I don’t know how, to generate a truly portable version of RT
Thanks for the kind explanation. I was able to change the install directory for the lens database. But even though I used the -DLENSFUNDBDIR=share/lensfun switch when I ran cmake, lensfun simply insisted looking for the database in the directory where it was originally installed.
I wanted to run RT in verbose mode, but I don’t know what exactly to do (could you please explain to me?). What makes the story even funnier is that I’m not to run RT in the console of MinGW. It simply quit, without a single piece of error message. To extract a little more information, I used GDB to run rawtherapee.exe. It turns out that RT exited with code 0xc0000139. Do you happen to know what that code means?
I created an automatic minimum profile with auto lens distortion correction, but the value applied was the one of one of the lens when creating the profile.
With lensfun, I hope most of the profile created will automatch to correct distortion, right?
(except with manual lenses, althoughtin the Raw their is the info of the focal lenght I give the camera…)
Thank you @noteasy2beme, @gaaned92, @agriggio, I usually delete the options file and cache for new versions, didn’t this time. It works now as expected.
Reviving this thread, now, July 2020, as I’ve recently made my first build on a win10 x64 laptop.
I’ve followed rawpedia instructions until the “Run CMake and Make” section.
But I can’t seem to find anything related to lensfun database; when I run RT-5.8 (dev branch), I can’t select any lens - and the share directory is empty.
~/RT/RawTherapee/build/release
$ ll
total 22624
drwxr-xr-x 1 catya None 0 16 juil. 16:34 .
drwxr-xr-x 1 catya None 0 10 mai 00:22 ..
-rw-r--r-- 1 catya None 733 10 mai 00:01 AboutThisBuild.txt
-rw-r--r-- 1 catya None 1236 9 mai 23:56 AUTHORS.txt
-rw-r--r-- 1 catya None 159083 9 mai 23:56 camconst.json
drwxr-xr-x 1 catya None 0 10 mai 00:22 dcpprofiles
drwxr-xr-x 1 catya None 0 10 mai 00:22 fonts
drwxr-xr-x 1 catya None 0 10 mai 00:22 iccprofiles
drwxr-xr-x 1 catya None 0 10 mai 00:22 images
drwxr-xr-x 1 catya None 0 10 mai 00:22 languages
-rw-r--r-- 1 catya None 33326 9 mai 23:56 LICENSE.txt
drwxr-xr-x 1 catya None 0 10 mai 00:22 licenses
-rw-r--r-- 1 catya None 2086 9 mai 23:56 options
drwxr-xr-x 1 catya None 0 10 mai 00:22 profiles
-rwxr-xr-x 1 catya None 15083188 10 mai 00:22 rawtherapee.exe
-rwxr-xr-x 1 catya None 7597536 10 mai 00:22 rawtherapee-cli.exe
-rw-r--r-- 1 catya None 4666 9 mai 23:56 RELEASE_NOTES.txt
drwxr-xr-x 1 catya None 0 10 mai 00:22 share
drwxr-xr-x 1 catya None 0 10 mai 00:22 sounds
drwxr-xr-x 1 catya None 0 10 mai 00:22 themes
-rw-r--r-- 1 catya None 11332 10 mai 00:01 WindowsInnoSetup.iss